Enhancement: Allow Disabling Indexing#5954
Enhancement: Allow Disabling Indexing#5954shamoon merged 4 commits intogethomepage:devfrom barreeeiroo:dev
Conversation
shamoon
left a comment
There was a problem hiding this comment.
Thanks. I will say the spirit of the feature request requirement is to allow for some input to suggest there is community interest in a feature, though I do expect there would be for this.
Also did you use AI for the PR?
|
Hi @shamoon, Yeah, I read the guideliness requiring all PRs to be "backed" by substantial interest in the community. However, I reckon that I literally opened the feature request just a few hours ago, and no interest has appeared (hopefully "yet"). Regarding the addition of extra maintenance, once I saw this project was using Next.js 15, I think it might require changes in the future... I've experienced the breaking updates which were introduced in earlier versions, so not sure if anything that I've used here (rewrite or And yes, I've used Claude Code to kinda help with understanding the repo (as it was the first time modifying it). I was expecting it to be more complex, but turned out to be a simple implementation. |
|
It just helps to know if AI was used so we can have a slightly better understanding of a PR authors abilities (both to generate the PR and / or deal with anything that arises). Yea I’m also not sure if this is the best way to do it, suppose I’ll have to look around / think. I agree I expect others will want this, honestly we have just found that even the most seemingly small/benign changes can have unintended consequences, hence asking for some demonstration of community interest before we agree to “take on” the changes. Of course many small changes don’t cause issues. |
|
So, I'm checking their docs for v15 using pages router, and it seems like this is the only way to achieve it... The only "official" way to achieve something similar without the rewrite is using the app router: |
|
I guess I dont know for sure but perhaps 'official' is the way to go, seems like it would be simple to adapt that to being dynamic based on the setting? |
|
But the issue is that the official cannot be implemented here, as homepage is using the pages router. I tried creating the file following the guide for the app router, but it just crashes in homepage if so.
|
|
Weird. I guess I’d have to play with it, it’s not something I know off the top of my head. but yea maybe not |
|
How feasible is it to migrate to the app router? Jk, this was one of the breaking changes I was referring to: they introduced the app router a while ago, but somehow the pages router is still there but seems like it has less features... |
|
Ah I see, yea I’m not familiar. Yea let’s not do that |
|
I think this is a bit cleaner. Take a look and LMK if you have any thoughts. I will note there are still 0 votes on your FR... of course its bare been a day |
|
Ah, didn't know you can manually write a response from The only thing I would change, but it's more of a nitpick, is that I would prefer to explicitly define as a string the possible content of Regarding the number of upvotes, yeah... I was just concerned because for some reason Google found my site, and having to manually request page removals is not fun. |
I just tested it and it most certainly does. Hmm, I guess Im a little ambivalent here, I suppose the setting would be about 10% easier? 😆 |
|
Well, the choice is yours haha. Ofc having the feature flag in settings makes it much easier and discoverable. But in case you want to go for the "do it yourself" approach, I would suggest to at least have it documented somewhere in the docs (not just in a discussion). :) |
Allows passing the disableIndexing parameter to settings in order to disable indexing in robots.txt and in the meta tag.
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
shamoon
left a comment
There was a problem hiding this comment.
Still no votes but I think we're ok here
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Proposed change
Allows passing the disableIndexing parameter to settings in order to disable indexing in robots.txt and in the meta tag.
Closes #5952
Type of change
Checklist:
AI Disclaimer
This change was built with the assistance of Generative AI.