Skip to content

Conversation

@VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jan 17, 2023

Since we have moved our main domain from porter.sh to getporter.org, we would like to keep things consistent across all projects. Therefore, this PR changes the apiGroup from porter.sh to getporter.org
close: #139

@VinozzZ VinozzZ force-pushed the rename-api-group-to-getporter-org branch from e80e81e to 4d2a337 Compare January 23, 2023 20:18
@VinozzZ VinozzZ force-pushed the rename-api-group-to-getporter-org branch from 4d2a337 to c46bca9 Compare January 23, 2023 21:13
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #140 (27af2b7) into main (0a68c40) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files          13       13           
  Lines        1536     1536           
=======================================
  Hits         1161     1161           
  Misses        242      242           
  Partials      133      133           
Flag Coverage Δ
unit-tests 75.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1/installation_types.go 75.00% <ø> (ø)
controllers/agentaction_controller.go 83.29% <ø> (ø)
controllers/agentconfig_controller.go 71.04% <ø> (ø)
controllers/credentialset_controller.go 77.61% <ø> (ø)
controllers/installation_controller.go 75.93% <ø> (ø)
controllers/parameterset_controller.go 77.61% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VinozzZ VinozzZ marked this pull request as ready for review January 23, 2023 21:32
@VinozzZ VinozzZ requested review from carolynvs and sgettys January 23, 2023 21:32
@carolynvs carolynvs self-assigned this Jan 24, 2023
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few files that also need to be updated:

  • PROJECT
  • tests/integration/suite_test.go (line 134)
  • main.go (line 57)

There are also some links that still reference our old v1 site that it would be nice to just quickly fix (release-v1.porter.sh -> getporter.org)

Signed-off-by: Yingrong Zhao <[email protected]>
@VinozzZ VinozzZ requested a review from carolynvs January 27, 2023 16:05
@VinozzZ VinozzZ merged commit bb4eaef into getporter:main Jan 30, 2023
@VinozzZ VinozzZ deleted the rename-api-group-to-getporter-org branch January 30, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the API Group from porter.sh/v1 to getporter.org/v1

2 participants