Allow installing multiple plugins

[VinozzZ]

This PR updated the porter dependency and the default porter-agent to v1.0.6. This allows us to take advantage of the new plugin file installing feature.
To match with the new plugins file schema, I had to update the AgentConfig resource definition. This will be a breaking change.
closes: #123

[codecov]

Codecov Report

Merging #141 (057a737) into main (bb4eaef) will increase coverage by 1.16%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   75.58%   76.75%   +1.16%     
==========================================
  Files          13       13              
  Lines        1536     1540       +4     
==========================================
+ Hits         1161     1182      +21     
+ Misses        242      227      -15     
+ Partials      133      131       -2     

Flag	Coverage Δ
unit-tests	76.75% <92.00%> (+1.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
controllers/agentconfig_controller.go	72.45% <71.42%> (+1.41%)	⬆️
api/v1/agentconfig_types.go	69.76% <100.00%> (+10.79%)	⬆️
controllers/agentaction_controller.go	83.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[carolynvs]

I'm a bit confused about why this representation of the document uses configs instead of plugins?

[VinozzZ]

spec:
  plugins:
    schemaVersion: 1.0.0
    configs:
      kubernetes: {}

This is what the schema looks like with the current implementation
If we change from Configs to Plugins, I find it a bit confusing to have Plugins under Spec.Plugins

[carolynvs]

The goal for any of our file formats is that they are copy pastable between when you are using them with the porter cli and the operator. Ideally, if someone had the following plugins.yaml they were using with porter,

schemaType: Plugins
schemaVersion: 1.0.0
plugins:
  azure:
    version: 1.0.1

Then they should be able to copy/paste it into a k8s manifest and use it without modifying (though they do need to paste it under the spec portion). So based on that I would expect the following to work

apiGroup: getporter.org/v1
Kind: AgentConfig
metadata:
  name: myconfig
spec:
  # normal agent config stuff
  plugins:
    # Copy/paste the plugins.yaml here
    schemaType: Plugins
    schemaVersion: 1.0.0
    plugins:
      azure:
        version: 1.0.1

I agree that the double plugins is a bit unwieldy. How about we rename AgentConfigSpec.Plugins to AgentConfigSpec.PluginConfigFile, which would also help clarify what goes under plugins? This way you would have a hint that the entire plugins file should be included in the field and not to just immediately start listing the plugins you want.

```yaml
apiGroup: getporter.org/v1
Kind: AgentConfig
metadata:
  name: myconfig
spec:
  # normal agent config stuff
  pluginConfigFile:
    # Copy/paste the plugins.yaml here
    schemaType: Plugins
    schemaVersion: 1.0.0
    plugins:
      azure:
        version: 1.0.1

What do you think?

[VinozzZ]

That's a very good point. I changed it based on your suggestions

[carolynvs]

You are using both plugins plural and singular here in the json/mapsturcture tags. I'm not sure which one you want to use?

[carolynvs]

I thought you were going to make it match the suggested schema from my last comment but this wasn't updated to be plugins so I'm a bit confused if you intended to match the suggestion or ?

[VinozzZ]

oops, the rebasing with the latest main really messed it up. I will fix it

[carolynvs]

Next time, if you leave the rebase for after the review is done, it's easier for me to review since I don't have to go over the entire thing again from scratch.

[carolynvs]

🎉

[carolynvs]

Looks great, thanks! 💖