fix race condition to createEmptyPluginVolume #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yingrong Zhao <[email protected]>
VinozzZ
requested review from
bdegeeter,
carolynvs and
sgettys
as code owners
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 76.75% 76.73% -0.02%
==========================================
Files 13 13
Lines 1540 1539 -1
==========================================
- Hits 1182 1181 -1
Misses 227 227
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carolynvs
approved these changes
Feb 8, 2023
Member
carolynvs
left a comment
carolynvs
left a comment
There was a problem hiding this comment.
I'm so glad you caught this! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Sometimes, a test in our CI build randomly times out when trying to install a plugin. see the log here: https://github.com/getporter/operator/actions/runs/4116258618/jobs/7106066540
I found that it's due to a race condition if two AgentConfig reconcile requests comes in around the same time before a AgentAction is created for installing a plugin.
Currently, this will cause two empty temporary plugin persistent volume claims being created. Then the rename for the plugin pvc will never proceed.
This PR fix the check that determine whether a plugin volume already exists.
What issue does it fix
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist