Fix documentation for PorterConfig #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getporter#142 changed the naming convention for the PorterConfig resource so that we can copy/paste between a porter config file and a PorterConfig resource, it missed a few bits of the documentation. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
requested review from
VinozzZ,
bdegeeter and
sgettys
as code owners
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 13 13
Lines 1544 1544
=======================================
Hits 1186 1186
Misses 227 227
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #142 changed the naming convention for the PorterConfig resource so that we can copy/paste between a porter config file and a PorterConfig resource, it missed a few bits of the documentation.