fix(publish): Fail early on dirty git repository #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dirty repository detection to `craft publish` to fail fast before any targets publish, matching the behavior of `craft prepare`. - Add shared `isRepoDirty` utility function to `src/utils/git.ts` - Add `--no-git-checks` CLI option for backward compatibility - Refactor `prepare.ts` to use the shared utility - Add tests for the new utility function Fixes #265
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Lms24
approved these changes
Dec 29, 2025
This was referenced Dec 29, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add dirty repository detection to
craft publishto fail fast before any targets publish, matching the behavior ofcraft prepare. Previously, if the repo was dirty during publish, it would fail late in the process (after targets had already published) whenhandleReleaseBranch()tried to checkout, merge, and push.Changes
isRepoDirty()utility function tosrc/utils/git.ts--no-git-checksCLI option to publish command for backward compatibilitypublishMain()before any git operationsprepare.tsto use the shared utility (reduces code duplication)isRepoDirtyfunctionFixes #265