Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Private key is not longer required for DSN#232

Merged
bruno-garcia merged 3 commits intodevelopfrom
feat/dsn-optional-private-key
Apr 6, 2018
Merged

Private key is not longer required for DSN#232
bruno-garcia merged 3 commits intodevelopfrom
feat/dsn-optional-private-key

Conversation

@bruno-garcia
Copy link
Member

The private DSNs (including secret keys) will be officially deprecated soon. This PR allows users to specify a public DSN and makes sure the sentry_secret is not included in the header anymore. For backwards compatibility, a private DSN can still be used, though.

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Apr 5, 2018

Travis has been broken for a while. Let's fix it in on a separate PR.
I'll just see if @asbjornu can take a look at the changes and we can merge.

docs/index.rst Outdated
protected override void ApplicationStartup(TinyIoCContainer container, IPipelines pipelines)
{
container.Register(new Dsn("http://public:secret@example.com/project-id"));
container.Register(new Dsn("http://public@example.com/project-id"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could use ___PUBLIC_DSN___ here to show an interactive DSN chooser in docs and the setup wizard:

container.Register(new Dsn("___PUBLIC_DSN___"));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@bruno-garcia bruno-garcia merged commit 3bfd915 into develop Apr 6, 2018
@bruno-garcia bruno-garcia deleted the feat/dsn-optional-private-key branch April 18, 2018 14:59
@mogikanin
Copy link

The question about dsn w/o private key. I tried to use dsn with only public key, but our sentry server doesn't accept such requests and return 403 error. Is it should be somehow configured on server side as well, or probably it's needed specific sentry version? We use 8.19.0

@jan-auer
Copy link
Member

jan-auer commented May 28, 2018

The private DSN is still required up to Sentry 8.22.0. The release of Sentry 9 to on-premise customers is just around the corner and will fix this.

Also note that some features introduced recently, such as the improved contexts, will require an updated sentry server.

@mogikanin
Copy link

ok, thanks @jan-auer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants