-
-
Notifications
You must be signed in to change notification settings - Fork 237
chore(metrics): Remove send_metric command #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
053ae2a to
142919b
Compare
142919b to
8f0cf5a
Compare
Metrics have been deprecated since October 7th 2024, so this is no longer valid, and we should remove instructions on how to send metrics, because this doesn't even work. This PR getsentry/sentry-cli#2710 will clean up metrics commands in CLI, but this can be cleaned up separately.
|
We will defer merging this PR until the next major. I have linked this PR under #2713, so we remember to merge it when we are releasing the next major. In the meantime, I will mark this PR as a draft |
|
Thanks @vgrozdanic! Lines 2786 to 2811 in 8f0cf5a
In this case it shouldn't cause problems, as we're not using the SDK "as an SDK" (e.g. we're not using the Hub at all), but could cause problems if we need to do so in the future, so let's remember to just upgrade |
|
To maintain a cleaner PR list, I'll close this PR for now. It should be easy to re-implement once we are ready to fully remove |
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (🥔 @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (🥔 @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (🥔 @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (🥔 @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (🥔 @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
Metrics have been deprecated on october 7th 2024, and since then it is not possible to send metrics.
This PR:
send_metricwhich is invalid since last October.sentry-corepackage to the latest version which has deprecated metrics