Skip to content

Conversation

@armcknight
Copy link
Member

I needed to be able to do this as part of running a sample app locally, but the way I'd conditionally compiled it out didn't allow that. Also compile this into debug builds.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryFileManager.m

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.217%. Comparing base (8ea5293) to head (2c217ff).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Sentry/SentryProfiler.mm 50.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5479       +/-   ##
=============================================
+ Coverage   85.773%   86.217%   +0.443%     
=============================================
  Files          400       401        +1     
  Lines        34802     34856       +54     
  Branches     14769     15113      +344     
=============================================
+ Hits         29851     30052      +201     
+ Misses        4909      4761      -148     
- Partials        42        43        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryFileManager.m 94.460% <ø> (+0.284%) ⬆️
Sources/Sentry/SentryProfiler.mm 90.303% <50.000%> (ø)

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea5293...2c217ff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.69 ms 1250.33 ms 26.63 ms
Size 23.75 KiB 854.79 KiB 831.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms

App size

Revision Plain With Sentry Diff
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB

@armcknight armcknight merged commit d637379 into main Jun 25, 2025
121 of 125 checks passed
@armcknight armcknight deleted the armcknight/test/wiping-data branch June 25, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants