-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat(v9): Remove deprecated SentryDebugImageProvider in V9 #5598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5598 +/- ##
=============================================
+ Coverage 86.326% 86.417% +0.090%
=============================================
Files 415 415
Lines 35295 35302 +7
Branches 15177 15370 +193
=============================================
+ Hits 30469 30507 +38
+ Misses 4784 4747 -37
- Partials 42 48 +6
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| fd5961e | 1210.59 ms | 1235.57 ms | 24.98 ms |
| 8fd192f | 1202.10 ms | 1220.19 ms | 18.09 ms |
| 2a36c3f | 1227.27 ms | 1246.89 ms | 19.63 ms |
| d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
| 409a607 | 1229.57 ms | 1251.45 ms | 21.88 ms |
| 4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
| 76f74df | 1238.29 ms | 1261.22 ms | 22.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| fd5961e | 23.74 KiB | 874.07 KiB | 850.32 KiB |
| 8fd192f | 23.74 KiB | 872.75 KiB | 849.01 KiB |
| 2a36c3f | 23.75 KiB | 874.45 KiB | 850.71 KiB |
| d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
| 409a607 | 23.74 KiB | 874.08 KiB | 850.33 KiB |
| 4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 76f74df | 23.75 KiB | 879.61 KiB | 855.86 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahsmartin, perhaps it makes sense to keep an internal deprecation changelog in /develop-docs, making it easier to create a proper changelog for V9. Finding all the PRs later could be challenging.
LGTM
|
Yeah I was thinking the same thing @philipphofmann I'll do that today |
This reverts commit 8ad303c.
This reverts commit 8ad303c.
Moves SentryDebugImageProvider to be an internal class for v9, visible only to the hybrid SDK. The only methods on this class that are currently public are deprecated and now removed behind the V9 flag.
#skip-changelog