Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Moves SentryDebugImageProvider to be an internal class for v9, visible only to the hybrid SDK. The only methods on this class that are currently public are deprecated and now removed behind the V9 flag.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0387950

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.417%. Comparing base (76f74df) to head (0387950).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Sentry/PrivateSentrySDKOnly.m 0.000% 3 Missing ⚠️
Sources/Sentry/SentryDebugImageProvider.m 96.774% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5598       +/-   ##
=============================================
+ Coverage   86.326%   86.417%   +0.090%     
=============================================
  Files          415       415               
  Lines        35295     35302        +7     
  Branches     15177     15370      +193     
=============================================
+ Hits         30469     30507       +38     
+ Misses        4784      4747       -37     
- Partials        42        48        +6     
Files with missing lines Coverage Δ
...ces/Sentry/SentryCrashDefaultBinaryImageProvider.m 100.000% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 88.372% <ø> (ø)
...ryCrash/Recording/Tools/SentryCrashDynamicLinker.c 90.595% <ø> (ø)
...ryCrash/Recording/Tools/SentryCrashDynamicLinker.h 100.000% <ø> (ø)
Sources/Sentry/SentryDebugImageProvider.m 88.281% <96.774%> (+0.281%) ⬆️
Sources/Sentry/PrivateSentrySDKOnly.m 24.019% <0.000%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f74df...0387950. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.70 ms 1242.04 ms 14.34 ms
Size 23.75 KiB 879.60 KiB 855.86 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7908e84 1224.33 ms 1246.39 ms 22.06 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
fd5961e 1210.59 ms 1235.57 ms 24.98 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
409a607 1229.57 ms 1251.45 ms 21.88 ms
4d264fa 1223.48 ms 1246.91 ms 23.44 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms

App size

Revision Plain With Sentry Diff
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
fd5961e 23.74 KiB 874.07 KiB 850.32 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
409a607 23.74 KiB 874.08 KiB 850.33 KiB
4d264fa 23.74 KiB 874.07 KiB 850.33 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahsmartin, perhaps it makes sense to keep an internal deprecation changelog in /develop-docs, making it easier to create a proper changelog for V9. Finding all the PRs later could be challenging.

LGTM

@noahsmartin
Copy link
Contributor Author

Yeah I was thinking the same thing @philipphofmann I'll do that today

@noahsmartin noahsmartin merged commit 8ad303c into main Jul 10, 2025
143 of 147 checks passed
@noahsmartin noahsmartin deleted the debugImageV9 branch July 10, 2025 14:27
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants