Skip to content

fix: Ensure video writer inputs are marked as finished on cancellation in SentryVideoFrameProcessor#5608

Merged
itaybre merged 3 commits intomainfrom
itay/mark_input_as_finished
Jul 10, 2025
Merged

fix: Ensure video writer inputs are marked as finished on cancellation in SentryVideoFrameProcessor#5608
itaybre merged 3 commits intomainfrom
itay/mark_input_as_finished

Conversation

@itaybre
Copy link
Copy Markdown
Contributor

@itaybre itaybre commented Jul 10, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.487%. Comparing base (8e3a42f) to head (33c9df3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5608       +/-   ##
=============================================
+ Coverage   86.401%   86.487%   +0.085%     
=============================================
  Files          415       415               
  Lines        35276     35270        -6     
  Branches     15109     15280      +171     
=============================================
+ Hits         30479     30504       +25     
+ Misses        4756      4722       -34     
- Partials        41        44        +3     
Files with missing lines Coverage Δ
...ions/SessionReplay/SentryVideoFrameProcessor.swift 96.212% <100.000%> (+0.058%) ⬆️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3a42f...33c9df3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.76 ms 1237.14 ms 27.39 ms
Size 23.75 KiB 880.33 KiB 856.57 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7148f97 1235.09 ms 1258.07 ms 22.98 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
fd5961e 1210.59 ms 1235.57 ms 24.98 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
884b224 1221.11 ms 1255.88 ms 34.77 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms
e0424b9 1204.23 ms 1241.08 ms 36.85 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms

App size

Revision Plain With Sentry Diff
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
fd5961e 23.74 KiB 874.07 KiB 850.32 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
884b224 23.75 KiB 879.55 KiB 855.80 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB
e0424b9 23.74 KiB 874.07 KiB 850.33 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB

@itaybre itaybre merged commit 43597ba into main Jul 10, 2025
124 of 127 checks passed
@itaybre itaybre deleted the itay/mark_input_as_finished branch July 10, 2025 19:10
@philipphofmann
Copy link
Copy Markdown
Member

Thank you @itaybre

philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
…cellation in SentryVideoFrameProcessor (getsentry#5608)"

This reverts commit 43597ba.
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
…cellation in SentryVideoFrameProcessor (getsentry#5608)"

This reverts commit 43597ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants