Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Remove the app hang v2 setting from SentryOptions when compiling the v9 SDK, now it is the default. There are other changes we could do after v9 is released to clean up some of the methods that take an isV2Enabled bool, but this just makes the public API changes that we want in v9

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 02d5649

@noahsmartin noahsmartin force-pushed the appHangeTrackerV2Options branch from 6734ade to 437718c Compare July 11, 2025 01:54
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.500%. Comparing base (ae7be93) to head (02d5649).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5615       +/-   ##
=============================================
+ Coverage   86.482%   86.500%   +0.018%     
=============================================
  Files          414       415        +1     
  Lines        35273     35291       +18     
  Branches     15298     15289        -9     
=============================================
+ Hits         30505     30527       +22     
- Misses        4722      4723        +1     
+ Partials        46        41        -5     
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 99.404% <100.000%> (+0.022%) ⬆️
Sources/Sentry/SentryBaseIntegration.m 95.512% <100.000%> (+0.028%) ⬆️
Sources/Sentry/SentryOptions.m 98.793% <100.000%> (+0.012%) ⬆️
...try/SentryWatchdogTerminationTrackingIntegration.m 85.897% <100.000%> (+0.371%) ⬆️
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <100.000%> (ø)

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae7be93...02d5649. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.06 ms 1263.59 ms 20.53 ms
Size 23.75 KiB 880.24 KiB 856.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
4d264fa 1223.48 ms 1246.91 ms 23.44 ms
5196f0d 1213.35 ms 1231.37 ms 18.02 ms

App size

Revision Plain With Sentry Diff
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
4d264fa 23.74 KiB 874.07 KiB 850.33 KiB
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB

Previous results on branch: appHangeTrackerV2Options

Startup times

Revision Plain With Sentry Diff
9403ea9 1211.21 ms 1245.94 ms 34.73 ms
5f91f0d 1225.31 ms 1247.30 ms 21.99 ms

App size

Revision Plain With Sentry Diff
9403ea9 23.75 KiB 880.14 KiB 856.40 KiB
5f91f0d 23.75 KiB 880.24 KiB 856.50 KiB

@noahsmartin noahsmartin force-pushed the appHangeTrackerV2Options branch 2 times, most recently from 221646a to 176e809 Compare July 11, 2025 02:23
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@noahsmartin noahsmartin force-pushed the appHangeTrackerV2Options branch from 176e809 to 02d5649 Compare July 11, 2025 13:51
@noahsmartin noahsmartin merged commit 04ff3ec into main Jul 11, 2025
127 checks passed
@noahsmartin noahsmartin deleted the appHangeTrackerV2Options branch July 11, 2025 15:47
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants