-
-
Notifications
You must be signed in to change notification settings - Fork 371
feat(v9): Remove app hang v2 option from SDK v9 #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
6734ade to
437718c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5615 +/- ##
=============================================
+ Coverage 86.482% 86.500% +0.018%
=============================================
Files 414 415 +1
Lines 35273 35291 +18
Branches 15298 15289 -9
=============================================
+ Hits 30505 30527 +22
- Misses 4722 4723 +1
+ Partials 46 41 -5
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| 8ad303c | 1220.02 ms | 1231.79 ms | 11.77 ms |
| 2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
| 7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
| cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
| 2a36c3f | 1227.27 ms | 1246.89 ms | 19.63 ms |
| 4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
| 5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 8ad303c | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
| 7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
| cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| 2a36c3f | 23.75 KiB | 874.45 KiB | 850.71 KiB |
| 4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
221646a to
176e809
Compare
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
176e809 to
02d5649
Compare
…)" This reverts commit 04ff3ec.
…)" This reverts commit 04ff3ec.
Remove the app hang v2 setting from SentryOptions when compiling the v9 SDK, now it is the default. There are other changes we could do after v9 is released to clean up some of the methods that take an
isV2Enabledbool, but this just makes the public API changes that we want in v9#skip-changelog