Explain how to configure filters for structured logs#16592
Explain how to configure filters for structured logs#16592jamescrosswell wants to merge 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
codeowner-assignment
bot
requested review from
a team
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation explaining how to configure filters for structured logs in both Serilog and Microsoft.Extensions.Logging integrations. It resolves issue #4952 by clarifying that structured log filtering is controlled differently from breadcrumbs and events.
Changes:
- Added explanatory text pointing users to the appropriate logging framework's filtering mechanisms for structured logs
- Added JSON configuration examples alongside existing C# code examples in the Serilog guide
- Added a note in the extensions-logging guide clarifying that filters only apply to breadcrumbs/events, not structured logs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/platforms/dotnet/guides/serilog/index.mdx | Added explanation about Serilog MinimumLogLevel for structured log filtering and two appsettings.json configuration examples |
| docs/platforms/dotnet/guides/extensions-logging/index.mdx | Added explanation about Microsoft.Extensions.Logging filtering, updated example configuration, and added a note clarifying filter scope |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Great improvement ... thanks ... I missed this after getsentry/sentry-dotnet#4700.
I got minor suggestions to link to the culture-agnostic docs from Microsoft.
| .CreateLogger(); | ||
| ``` | ||
|
|
||
| ```json {filename:appsettings.json} |
There was a problem hiding this comment.
praise: I love the json additions to the existing csharp snippet 🥔
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
cc: @Flash0ver for review
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: