Logging-Configuration is not applied to Sentry-Logger-Provider

[Flash0ver]

Description

Logging-Configuration (e.g. appsettings.json: Logging:LogLevel:Default) is not applied to Sentry-Logger-Provider

• Sentry.Extensions.Logging
  • Events & Breacrumbs
  • Structured Logs
• Sentry.AspNetCore
  • Structured Logs

For Breadcrumbs and Events, the Logging-Configuration is applied in Sentry.AspNetCore.

Also consider and review the Serilog integration (see #4462 (comment)).

---

Thanks @wondertalik for discovering and reporting the issue.
See #4132 (comment).

[linear]

NET-456 Logging-Configuration is not applied to Sentry-Logger-Provider

[Flash0ver]

TIL, when adding a LoggerFilterRule (via AddFilter) we opt-out of the "Minimum-Log-Level-From-Configuration" rule:

sentry-dotnet/src/Sentry.Extensions.Logging/LoggingBuilderExtensions.cs

Line 60 in 6ea6bf4

builder.AddFilter<SentryLoggerProvider>(_ => true);

But just adding a Category and Level, just as via appsettings.json, does not replace the default rule:

sentry-dotnet/src/Sentry.AspNetCore/SentryWebHostBuilderExtensions.cs

Lines 98 to 100 in 6ea6bf4

	_ = logging.AddFilter<SentryAspNetCoreLoggerProvider>(
	"Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware",
	LogLevel.None);

[Flash0ver]

Indeed ... the intended behavior for Structured Logs is to be configurable through "standard" Logging-Configuration, like appsettings.json.
For Breadcrumbs and Events we have explicit Sentry-Options:

• Sentry.Extensions.Logging.SentryLoggingOptions.MinimumBreadcrumbLevel
• Sentry.Extensions.Logging.SentryLoggingOptions.MinimumEventLevel

But we got different behavior in Sentry.Extensions.Logging and Sentry.AspNetCore

• Configuration added for Microsoft.Extensions.Logging is ignored and only the options are evaluated.
• Usually, in ASP.NET Core, there is configuration and this it is included in the IsEnabled-Check (before the options are evaluated).

For Sentry.Extensions.Logging, see:

sentry-dotnet/src/Sentry.Extensions.Logging/LoggingBuilderExtensions.cs

Lines 57 to 60 in 6ea6bf4

	// All logs should flow to the SentryLogger, regardless of level.
	// Filtering of events is handled in SentryLogger, using SentryOptions.MinimumEventLevel
	// Filtering of breadcrumbs is handled in SentryLogger, using SentryOptions.MinimumBreadcrumbLevel
	builder.AddFilter<SentryLoggerProvider>(_ => true);

Questions:

Breadcrumbs + Events

• Should Sentry.Extensions.Logging and all inheriting SDKs (like Sentry.AspNetCore) have the same behavor, or is it intended that there is different behavior?
  • If the behavior should be identical, should it include Configuration, or only consider SentryLoggingOptions?

Structured Logs

• Should the behavior be different or identical for Breadcrumbs+Events and Structured Logs?
  • In other words, do we only want Logging-Configuration, like appsettings.json (originally intended)
  • or should we only have a MinimumLogLevel in SentryLoggingOptions
  • or both, where the Logging-Configuration is applied first, and then the SentryLoggingOptions are evaluated

[wondertalik]

Hi, there.

Just MinimumLogLevel it's not enough for sure. It's my biggest pain right now. The logs in sentry have a lot of noisy logs. I have diferent level for specific categories, some warning, some information or error. Using opentelemetry and otel collector standard logging configuration give me option filter that before send to anywhere else. But right now sentry is just collecting everything.

Thanks for your work, btw.