Introduce scope stack abstraction#1124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
+ Coverage 80.64% 80.65% +0.01%
==========================================
Files 197 200 +3
Lines 6592 6612 +20
Branches 1455 1460 +5
==========================================
+ Hits 5316 5333 +17
- Misses 802 804 +2
- Partials 474 475 +1
Continue to review full report at Codecov.
|
bruno-garcia
left a comment
There was a problem hiding this comment.
I like where this is going!
I think the direction you're going for a test for each approach is a good one. Let me take another look once it's out of draft to propose some integration/unit tests |
|
@bruno-garcia what do you think about the general implementation by the way? I know you said there are a lot of potential edge-cases/hidden issues, so I'm somewhat skeptical about my solution given how easy it was to implement 😅 It could benefit to put some more responsibility inside |
|
We need to ship this and add some docs |
Closes #1106
Closes #628
Related to #221, #448, #505
Not entirely sure how to test this. Ideas @bruno-garcia?