-
-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Associate replays with errors and traces on Android #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #2136 Associate Errors and Traces with the active Session Replay (if one exists) on Android.
Contributor
|
10 tasks
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
Merged
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2136
Associate Errors and Traces with the active Session Replay (if one exists) on Android.
Protocol
Although there is a new Replay context, I found that just setting the replay_id on that context (e.g. for an event) did not result in the event showing in the errors pane for session replays.
What was recommended, and work better, is to store the
replay_idon the DSC (which will accompany all events) and let Relay unpack it from there. The DSC specification mentionsreplay_idas an optional property on the dynamic sampling context.Getting the Replay ID
There are three ways the DSC can be created:
In all 3 cases, we check to see if there's a Session Replay actively being recorded. If there is, we either set (or overwrite) the
replay_idthat int he DSC. If there's not, we just propagate whatever is in the header.This is a bit different to what we normally do with the baggage headers, so there are quite a few new scenarios to unit test.