Skip to content

chore: move Benchmarks for Sentry.Extensions.Logging into separate project#5146

Merged
jamescrosswell merged 7 commits intomainfrom
chore/sentry.extensions.logging.benchmarks
Apr 23, 2026
Merged

chore: move Benchmarks for Sentry.Extensions.Logging into separate project#5146
jamescrosswell merged 7 commits intomainfrom
chore/sentry.extensions.logging.benchmarks

Conversation

@Flash0ver
Copy link
Copy Markdown
Member

@Flash0ver Flash0ver commented Apr 21, 2026

Summary

Move the Benchmark for Sentry.Extensions.Logging into a new Sentry.Extensions.Logging.Benchmarksproject.

Remarks

In #4308, I broke the SentryCore.slnf filtered solution, by adding a dependency to Sentry.Extensions.Logging in the Sentry.Benchmarks project.
See eadf5f2#diff-a68c64a5b74a24eb0d8d7d04aeb893acd2358768b2e0efe3a747d79199a0bea1R17.

Fixing this problem (without pulling in a bunch of projects into SentryCore.slnf) by separating the Benchmarks for Microsoft.Extensions.Logging into a new separate Benchmarking project.

This structure also now mimics /tests/, where we have one Test-Project per Project-Under-Test.

@Flash0ver Flash0ver added the skip-changelog Suppress automatic changelog generation via Craft label Apr 21, 2026
@Flash0ver Flash0ver self-assigned this Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.


<Import Project="..\Directory.Build.props" />

<!-- Never use Sentry CLI for benchmark projects. -->
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: remove redundant comment

<UseSentryCLI>false</UseSentryCLI> was removed via 91b22a9#diff-f431a929d80ac5e052346ee209d3600c6f7385325f3811b74dbba9bf66c21054L7, but the comment remained.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (3d46788) to head (1f35f7e).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5146   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         501      501           
  Lines       18111    18111           
  Branches     3521     3521           
=======================================
  Hits        13415    13415           
  Misses       3837     3837           
  Partials      859      859           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>$(PreviousTfm)</TargetFramework>
<IsPackable>false</IsPackable>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: removing, as already declared in "parent" Directory.Build.props

@Flash0ver Flash0ver marked this pull request as ready for review April 23, 2026 13:45

namespace Sentry.Extensions.Logging.Benchmarks;

internal class Program
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: code duplication

This file pretty much is a duplicate from the existing benchmarks/Sentry.Benchmarks/Program.cs, except for the namespace ... which we could argue is fine to keep in the default namespace of the project when using Top-Level-Statements instead.

Should we have more Benchmark-Projects in the future, we could have a single .cs file, that we <Compile Include="..." /> across all projects.
Or we do that right away already.

@jamescrosswell jamescrosswell merged commit e6e872c into main Apr 23, 2026
47 checks passed
@jamescrosswell jamescrosswell deleted the chore/sentry.extensions.logging.benchmarks branch April 23, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Suppress automatic changelog generation via Craft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants