fix(replay): Fix IllegalArgumentException when Bitmap is initialized with non-positive values
#4536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
lcian,
markushi and
stefanosiano
as code owners
romtsn
changed the title
IllegalArgumentException when Bitmap is initialized with non-positive values
Contributor
Performance metrics 🚀
|
lcian
approved these changes
Jul 3, 2025
romtsn
added a commit
that referenced
this pull request
Jul 9, 2025
…zed with non-positive values (#4536) * fix(replay): Fix crash when hasSize returns true for negative values * spotless * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Apparently
widthandheightcan return negative values, so our != 0 check was not enough💡 Motivation and Context
https://sentry.sentry.io/issues/6713535878/events/318005d8a00a468abccdd5f4f5576f28/
💚 How did you test it?
With tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps