feat(native): symbolicate stack frames in crash daemon on Windows#1595
Open
feat(native): symbolicate stack frames in crash daemon on Windows#1595
Conversation
Call SymFromAddrW during the StackWalk64 loop to resolve function names and symbol addresses for each frame. This populates the "function" and "symbol_addr" fields on native stacktrace frames, giving more useful crash reports without relying on server-side symbolication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
jpnurmi
requested review from
JoshuaMoelans,
mujacica,
supervacuus and
tustanivsky
mujacica
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
SymFromAddrWduring theStackWalk64loop to resolve function names and symbol addresses for each frame. This populates the "function" and "symbol_addr" fields on native stacktrace frames, giving more useful external crash reports.https://develop.sentry.dev/sdk/foundations/transport/event-payloads/stacktrace/