Fix PowerShell 7.5.2+ compatibility for SynchronousTransport#105
Merged
Conversation
PowerShell 7.5.2 introduced changes to property assignment in class constructors when inheriting from .NET base classes. This caused SynchronousTransport to fail with "The property 'ProcessEnvelope' cannot be found on this object" errors. Changes: - Replace individual [System.Reflection.MethodInfo] properties with a single hashtable to store reflection methods - Add null checks for all reflection-based lookups to provide clear error messages if Sentry SDK internals change - Remove 'hidden' keyword from logger property (no longer needed) This fix is backward compatible and works with both PowerShell 7.5.2+ and earlier versions. Fixes #91 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compatibility issues with PowerShell 7.5.2+ by addressing breaking changes in how property assignment works in class constructors that inherit from .NET base classes.
Problem
PowerShell 7.5.2 introduced changes that caused
SynchronousTransportto fail during initialization with the error:This occurred because PowerShell changed how it handles property assignment in constructors when a class inherits from a .NET base class and calls
: base($options).Solution
hidden [System.Reflection.MethodInfo] $ProcessEnvelope[hashtable] $reflectionMethods = @{}hiddenkeyword from logger property (no longer needed for compatibility)Testing
All tests pass with PowerShell 7.5.3:
Backward Compatibility
This fix is fully backward compatible and works with:
References
Fixes #91
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com