Remove scope.span = setter and make sure scope.span reference is correct in context manager regardless of source of span
#4439
Codecov / codecov/project
succeeded
Jun 4, 2025 in 1s
84.80% (-0.07%) compared to 1b839c5
View this Pull Request on Codecov
84.80% (-0.07%) compared to 1b839c5
Details
Codecov Report
Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
Project coverage is 84.80%. Comparing base (
1b839c5) to head (5dba74b).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/celery/__init__.py | 66.66% | 0 Missing and 1 partial |
Additional details and impacted files
@@ Coverage Diff @@
## neel/fix-decorator #4439 +/- ##
======================================================
- Coverage 84.86% 84.80% -0.07%
======================================================
Files 144 144
Lines 14726 14725 -1
Branches 2342 2343 +1
======================================================
- Hits 12497 12487 -10
- Misses 1516 1523 +7
- Partials 713 715 +2 | Files with missing lines | Coverage Δ | |
|---|---|---|
| sentry_sdk/opentelemetry/contextvars_context.py | 100.00% <100.00%> (ø) |
|
| sentry_sdk/scope.py | 82.22% <ø> (-0.09%) |
⬇️ |
| sentry_sdk/tracing.py | 80.35% <ø> (-0.21%) |
⬇️ |
| sentry_sdk/integrations/celery/__init__.py | 91.02% <66.66%> (ø) |
Loading