Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 26, 2025

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.77%. Comparing base (8d6fbe7) to head (1d19212).

❗ There is a different number of reports uploaded between BASE (8d6fbe7) and HEAD (1d19212). Click for more details.

HEAD has 91 uploads less than BASE
Flag BASE (8d6fbe7) HEAD (1d19212)
114 23
Additional details and impacted files
@@                      Coverage Diff                       @@
##           neel/remove-enable-tracing    #2732      +/-   ##
==============================================================
- Coverage                       97.40%   90.77%   -6.64%     
==============================================================
  Files                             142      135       -7     
  Lines                            5625     5354     -271     
==============================================================
- Hits                             5479     4860     -619     
- Misses                            146      494     +348     
Components Coverage Δ
sentry-ruby 98.57% <ø> (+0.88%) ⬆️
sentry-rails 42.75% <ø> (-53.77%) ⬇️
sentry-sidekiq 95.05% <ø> (-1.53%) ⬇️
sentry-resque 94.20% <ø> (-0.25%) ⬇️
sentry-delayed_job 95.65% <ø> (+0.97%) ⬆️
sentry-opentelemetry 100.00% <ø> (+0.68%) ⬆️
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/configuration.rb 89.28% <ø> (-10.72%) ⬇️
sentry-ruby/lib/sentry/configuration.rb 98.43% <ø> (+0.27%) ⬆️

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py requested a review from solnic September 26, 2025 13:18
@sl0thentr0py sl0thentr0py mentioned this pull request Sep 26, 2025
@sl0thentr0py sl0thentr0py merged commit a697d6a into neel/remove-enable-tracing Sep 26, 2025
6 of 7 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/remove-deprec-logger branch September 26, 2025 14:36
sl0thentr0py added a commit that referenced this pull request Sep 26, 2025
* Remove deprecated config.enable_tracing

* Remove deprecated `config.logger` (#2732)

* Remove deprecated config.logger

* Remove deprecated Sentry::Rails::Tracing::ActionControllerSubscriber (#2733)
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove deprecated `config.logger` ([#2732](https://github.com/getsentry/sentry-ruby/pull/2732))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 1d19212

sl0thentr0py added a commit that referenced this pull request Sep 26, 2025
* Remove deprecated config.enable_tracing

* Remove deprecated `config.logger` (#2732)

* Remove deprecated config.logger

* Remove deprecated Sentry::Rails::Tracing::ActionControllerSubscriber (#2733)
sl0thentr0py added a commit that referenced this pull request Sep 26, 2025
* Remove deprecated capture_exception_frame_locals

* Remove deprecated config.enable_tracing (#2731)

* Remove deprecated config.enable_tracing

* Remove deprecated `config.logger` (#2732)

* Remove deprecated config.logger

* Remove deprecated Sentry::Rails::Tracing::ActionControllerSubscriber (#2733)
sl0thentr0py added a commit that referenced this pull request Oct 22, 2025
* Drop `async` configuration (#1894)

* Migrate from to_hash to to_h (#2351)

* Migrate from to_hash to to_h

As @solnic pointed out in #2350 (comment)
`to_hash` has special meaning in Ruby and could be called implicitly
in contexts like double splatting argument. So we should switch to `to_h`
to avoid potential issues.

* Fix specs after rebase

* Add before_send_check_in (#2703)

* Cleanup before_send to only apply to ErrorEvent
* remove the Hash deprecation message

* Archive sentry-raven (#2708)

Moved to https://github.com/getsentry/raven-ruby

* Remove stacktrace trimming from the SDK (#2714)

* Default config.enabled_environments to nil instead of [] (#2716)

* Remove :monotonic_active_support_logger (#2717)

* Add `config.trace_ignore_status_codes` to control which status codes don't get traced (#2725)

* Add config.trace_ignore_status_codes to control which status codes don't
get traced

* Change implementation to Range

* Don't send  client reports for profiles if profiling is disabled (#2728)

* Remove  and  and all metrics related code (#2729)

* Remove deprecated `config.capture_exception_frame_locals` (#2730)

* Remove deprecated capture_exception_frame_locals

* Remove deprecated config.enable_tracing (#2731)

* Remove deprecated config.enable_tracing

* Remove deprecated `config.logger` (#2732)

* Remove deprecated config.logger

* Remove deprecated Sentry::Rails::Tracing::ActionControllerSubscriber (#2733)

* Remove Transaction deprecations (#2736)

* Remove deprecated Event#configuration (#2740)

* Remove deprecated client methods (#2741)

* Bump required_ruby_version to 2.7 (#2743)

* Bump minimum rails version in `sentry-rails` to `5.2.0`
* Bump minimum sidekiq version in `sentry-sidekiq` to `5.0`
* Cleanup CI

* Remove hub from Transaction#initialize (#2739)

* Move examples out of SDK (#2746)

available at https://github.com/getsentry/examples/tree/master/ruby

* Add new config.profiles_sample_interval (#2745)

* Always set up the StructuredLogger and no-op capture_log_event if logs (#2752)

are disabled

* Make request body reading safe to rewind (#2754)

* Bump oversized stacktrace trunction to 500 on both sides

Revert "Remove stacktrace trimming from the SDK (#2714)"

This reverts commit ed7a2db.

---------

Co-authored-by: Stan Lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants