Skip to content

chore(billing): add constants for emerge#106235

Merged
vbro merged 5 commits intomasterfrom
vbro_emerge_constants_fe
Jan 16, 2026
Merged

chore(billing): add constants for emerge#106235
vbro merged 5 commits intomasterfrom
vbro_emerge_constants_fe

Conversation

@vbro
Copy link
Copy Markdown
Contributor

@vbro vbro commented Jan 13, 2026

Data category constants for emerge products

@vbro vbro requested a review from a team January 13, 2026 23:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 13, 2026
productName: t('Size Analysis Upload'),
uid: 35,
isBilledCategory: false,
statsInfo: {...DEFAULT_STATS_INFO, showExternalStats: true},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, if you set showExternalStats to true without adding additional checks here the category will show up as an option in stats for everybody

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is showExternalStats for stats page only?
It also affects Subscription Page, because Subscription Page also uses chartMetadata.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only for stats page, the chartMetadata you're referring to in subscription page is a completely separate function from the one in stats

@vbro vbro merged commit 7f043df into master Jan 16, 2026
53 checks passed
@vbro vbro deleted the vbro_emerge_constants_fe branch January 16, 2026 17:22
BYK pushed a commit that referenced this pull request Jan 19, 2026
dashed added a commit that referenced this pull request Jan 21, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants