fix(tempest): Add more metrics, logs and spans for monitoring#107041
fix(tempest): Add more metrics, logs and spans for monitoring#107041JoshuaMoelans merged 10 commits intomasterfrom
Conversation
mujacica
commented
Jan 27, 2026
- Add more metrics, logs and spans for monitoring
|
@sentry review |
|
@cursor review |
|
@cursor review |
|
@sentry review |
|
@cursor review |
tobias-wilfert
left a comment
There was a problem hiding this comment.
Just left a couple comments, but overall nice should give us much better insight in what is actually happening.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
1ed817a to
d4b0c40
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
|
|
||
| def _poll_tempest_crashes_impl(credentials_id: int) -> None: | ||
| """Implementation of poll_tempest_crashes, separated for locking.""" |
There was a problem hiding this comment.
Missing deleted-credentials guard in poll crashes implementation
Medium Severity
_poll_tempest_crashes_impl uses .get() to fetch credentials, while _fetch_latest_item_id_impl was updated to use .filter().first() with a graceful None check. If credentials are deleted between task scheduling and execution, .get() raises DoesNotExist outside the try/except block, causing an unhandled exception that propagates through the lock context and crashes the task without any metrics or logging.
Additional Locations (1)
Backend Test FailuresFailures on
|
ec868a8 to
8708840
Compare
Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
8708840 to
fd5296f
Compare

