Skip to content

fix(tempest): Add more metrics, logs and spans for monitoring#107041

Merged
JoshuaMoelans merged 10 commits intomasterfrom
fix/tempest_monitoring
Mar 3, 2026
Merged

fix(tempest): Add more metrics, logs and spans for monitoring#107041
JoshuaMoelans merged 10 commits intomasterfrom
fix/tempest_monitoring

Conversation

@mujacica
Copy link
Contributor

  • Add more metrics, logs and spans for monitoring

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 27, 2026
@mujacica
Copy link
Contributor Author

@sentry review

@mujacica
Copy link
Contributor Author

@cursor review

@mujacica
Copy link
Contributor Author

@cursor review

@mujacica
Copy link
Contributor Author

@sentry review

@mujacica
Copy link
Contributor Author

@cursor review

@mujacica mujacica marked this pull request as ready for review January 27, 2026 14:02
@mujacica mujacica requested a review from a team as a code owner January 27, 2026 14:02
Copy link
Member

@tobias-wilfert tobias-wilfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple comments, but overall nice should give us much better insight in what is actually happening.

@getsantry
Copy link
Contributor

getsantry bot commented Feb 20, 2026

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Feb 20, 2026
@getsantry getsantry bot closed this Feb 28, 2026
@JoshuaMoelans JoshuaMoelans reopened this Mar 2, 2026
@JoshuaMoelans JoshuaMoelans force-pushed the fix/tempest_monitoring branch 2 times, most recently from 1ed817a to d4b0c40 Compare March 2, 2026 08:26
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.



def _poll_tempest_crashes_impl(credentials_id: int) -> None:
"""Implementation of poll_tempest_crashes, separated for locking."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing deleted-credentials guard in poll crashes implementation

Medium Severity

_poll_tempest_crashes_impl uses .get() to fetch credentials, while _fetch_latest_item_id_impl was updated to use .filter().first() with a graceful None check. If credentials are deleted between task scheduling and execution, .get() raises DoesNotExist outside the try/except block, causing an unhandled exception that propagates through the lock context and crashes the task without any metrics or logging.

Additional Locations (1)

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Backend Test Failures

Failures on 98711f6 in this run:

tests/sentry/tempest/test_tempest.py::TempestTasksTest::test_fetch_latest_item_id_invalid_scopelog
tests/sentry/tempest/test_tempest.py:103: in test_fetch_latest_item_id_invalid_scope
    assert self.credentials.message == (
E   AssertionError: assert '' == 'Seems like t... wrong scope.'
E     
E     - Seems like the provided credentials have the wrong scope.

@JoshuaMoelans JoshuaMoelans force-pushed the fix/tempest_monitoring branch from 8708840 to fd5296f Compare March 2, 2026 11:57
@JoshuaMoelans JoshuaMoelans merged commit 41d2c12 into master Mar 3, 2026
75 checks passed
@JoshuaMoelans JoshuaMoelans deleted the fix/tempest_monitoring branch March 3, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants