feat: rewrite account details to new form system#107264
Merged
natemoo-re merged 94 commits intomasterfrom Feb 17, 2026
Merged
Conversation
# Conflicts: # package.json # pnpm-lock.yaml
JonasBa
approved these changes
Feb 17, 2026
natemoo-re
approved these changes
Feb 17, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
natemoo-re
deleted the
tkdodo/feat/de-790-rewrite-account-details-to-new-form-system
branch
1 task
natemoo-re
added a commit
that referenced
this pull request
Feb 17, 2026
Follow-up to #107264. The previous `JSONForm` system managed automatic scrolling based on the URL hash. In #107264, we tried to replicate that but overcomplicated things with a `useEffect` call. In this PR, we introduce a ref callback on the `label` element, automatically handle hash scrolling, and call `label.control.focus()` to focus on the form field's input.
TkDodo
commented
Feb 18, 2026
TkDodo
commented
Feb 18, 2026
| // endpoint returns a partial `User` without `options` and other fields. | ||
| setApiQueryData<User>(queryClient, USER_ENDPOINT_QUERY_KEY, previousData => { | ||
| if (!previousData) { | ||
| return userData as User; |
Collaborator
Author
There was a problem hiding this comment.
we’d want to return undefined here to bail out of updates.
Collaborator
Author
There was a problem hiding this comment.
also if the USER_ENDPOINT return partial data, we have to change the type of fetchMutation<User> to <fetchMutation<Partial<User>>
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: Nate Moore <nate.moore@sentry.io> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
Follow-up to #107264. The previous `JSONForm` system managed automatic scrolling based on the URL hash. In #107264, we tried to replicate that but overcomplicated things with a `useEffect` call. In this PR, we introduce a ref callback on the `label` element, automatically handle hash scrolling, and call `label.control.focus()` to focus on the form field's input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.