Conversation
…_timeseries_by_project_and_release`
github-actions
bot
added
the
Scope: Backend
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Outdated
Show resolved
Hide resolved
…errors-counts-timeseries
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
…errors-counts-timeseries
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Outdated
Show resolved
Hide resolved
…errors-counts-timeseries
… instead of query string
…errors-counts-timeseries
…errors-counts-timeseries
…errors-counts-timeseries
…errors-counts-timeseries
| query_parts: list[str] = [] | ||
|
|
||
| if len(release_value_list) == 1: | ||
| query_parts.append(f'release:"{release_value_list[0]}"') |
There was a problem hiding this comment.
may need to escape release/environment values here? i'm actually not sure
There was a problem hiding this comment.
Are you saying escape from a security perspective or from a correctness perspective?
From a security perspective, I feel that the fact we already add a default org/project filter via SnubaParams should be sufficient.
There was a problem hiding this comment.
for correctness - e.g. if the environment/release name contains a double quote character (not sure if we allow this)
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Outdated
Show resolved
Hide resolved
| query_parts: list[str] = [] | ||
|
|
||
| if len(release_value_list) == 1: | ||
| query_parts.append(f'release:"{release_value_list[0]}"') |
There was a problem hiding this comment.
Are you saying escape from a security perspective or from a correctness perspective?
From a security perspective, I feel that the fact we already add a default org/project filter via SnubaParams should be sufficient.
shashjar
deleted the
implement-eap-occurrence-double-reads-get-errors-counts-timeseries
branch
2 participants
Implements double reads of occurrences from EAP for
get_errors_counts_timeseries_by_project_and_releaseinsrc/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py.