feat(discover): Add conditional functions and tpm to allowed arithmetic functions#107958
Merged
DominikB2014 merged 3 commits intomasterfrom Feb 10, 2026
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
edwardgou-sentry
approved these changes
Feb 10, 2026
Contributor
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
There was a problem hiding this comment.
count_if is already on the list
DominikB2014
deleted the
dominikbuszowiecki/browse-310-add-tpmavg_ifetc-as-allowed-functions-for-equations
branch
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…ic functions (#107958) ## Summary Adds support for conditional aggregate functions and transactions per minute (tpm) to the arithmetic operations allowed in Discover queries and dashboard equations. Following the pattern #107941 ## Changes - Added `tpm` function for transactions per minute calculations - Added conditional aggregate functions with `_if` suffix: - Percentiles: `p50_if`, `p75_if`, `p90_if`, `p95_if`, `p99_if` - Aggregates: `sum_if`, `avg_if`, `count_if` - Custom: `division_if`, `failure_rate_if` ## Context The frontend overview dashboard uses these functions in its widget equations. Without these being added to the allowed functions list, equations using these functions would fail validation.
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for conditional aggregate functions and transactions per minute (tpm) to the arithmetic operations allowed in Discover queries and dashboard equations. Following the pattern #107941
Changes
tpmfunction for transactions per minute calculations_ifsuffix:p50_if,p75_if,p90_if,p95_if,p99_ifsum_if,avg_if,count_ifdivision_if,failure_rate_ifContext
The frontend overview dashboard uses these functions in its widget equations. Without these being added to the allowed functions list, equations using these functions would fail validation.