feat(tracemetrics): Expose unit type in metrics UI#108036
Merged
narsaynorath merged 15 commits intomasterfrom Feb 26, 2026
Merged
feat(tracemetrics): Expose unit type in metrics UI#108036narsaynorath merged 15 commits intomasterfrom
narsaynorath merged 15 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Aci
Admin
Agent
Agents
Ai Conversations
Ai Insights
Autofix
Autopilot
Billing
Cells
Code Review
Conversations
Copilot
Core
Crons Detector Schedule Preview
Dashboards
Dynamic Grouping
Dynamic Sampling
Eco
Explore
Grouping
Infra
Integrations
Issue Details
Issues
Js Loader
Lint
Llm Detection
Notifications
Oauth
Objectstore
Occurrences On Eap
Onboarding
Preprod
Replay
Replays
Search Agent
Seer
Seer Explorer
Sentry Apps
Settings
Spans
Spans Buffer
Toolbar
Trace
Tracemetrics
Ui
Uptime
Uptime Assertion Failure Data
Other
Bug Fixes 🐛Aci
Agent Insights
Agents
Ai Conversations
Ai Insights
Alerts
Auth
Autofix
Autopilot
Billing
Cells
Code Mappings
Code Review
Codeowners
Cursor
Dashboards
Data Forwarding
Eap
Explore
Explorer
Forms
Github Copilot
Grouping
Infra
Insights
Issue Details
Issues
Lint
Notifications
Onboarding
Preprod
Releases
Replay
Seer
Settings
Span Buffer
Spans Migration
Stories
Tests
Top Issues
Trace Waterfall
Tracemetrics
Typing
Ui
Uptime
Users
Other
Documentation 📚
Internal Changes 🔧Aci
Agent
Agents
Alerts
Api
Autofix
Autopilot
Billing
Cells
Code Review
Code Review
Codeowners
Conversations
Cross Event
Dashboards
Deps
Dynamic Sampling
Eslint
Explorer
Forms
Grouping
Infra
Integrations
Issues
Llm Detection
Open Periods
Ownership
Preprod
Promotions
Relay
Replay
Routes
Scraps
Seer
Sentry Apps
Slack
Span Buffer
Spans
Stories
Tests
Theme
Tracemetrics
Ui
Uptime
Workflow Engine
Other
Other
Plus 102 more 🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
k-fish
approved these changes
Feb 19, 2026
static/app/views/explore/metrics/metricToolbar/metricSelector.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment on lines
74
to
81
| name: metricOptions[0].metricName, | ||
| type: metricOptions[0].metricType, | ||
| unit: hasMetricUnitsUI ? (metricOptions[0].metricUnit ?? NONE_UNIT) : undefined, | ||
| }); | ||
| } | ||
| }, [metricOptions, onChange, traceMetric.name]); | ||
| }, [metricOptions, onChange, traceMetric.name, hasMetricUnitsUI]); | ||
|
|
||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const debouncedSetSearch = useCallback( |
Contributor
There was a problem hiding this comment.
Bug: Inconsistent default values for missing metric units ('-' vs. 'none') cause comparison failures in the metric selector, breaking backward compatibility for old widgets.
Severity: HIGH
Suggested Fix
Unify the default value for missing or undefined metric units across the application. Either consistently use '-', 'none', or undefined and ensure that makeMetricSelectValue and the logic in metricSelector.tsx handle the chosen default value correctly for both the current metric and the options from the API.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/explore/metrics/metricToolbar/metricSelector.tsx#L74-L81
Potential issue: When the `tracemetrics-units-ui` feature is enabled, there is
inconsistent handling of missing metric units. Metrics from older widgets have their
unit placeholder `'-'` parsed into `undefined`. In the metric selector, this `undefined`
unit is defaulted to `'-'` for the currently selected metric. However, when comparing
against the list of available metrics from the API, a missing unit is defaulted to
`'none'`. This discrepancy causes the string comparison in `makeMetricSelectValue` to
fail (e.g., `'name||type||-'` does not equal `'name||type||none'`), preventing the
currently selected metric from being correctly identified in the dropdown and
potentially causing it to be duplicated.
narsaynorath
deleted the
nar/feat/tracemetrics-expose-unit-type-in-ui
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the unit type for the metric in the selector for both Explore and Dashboards. Alerts will follow in another PR.
For the selector, we've denoted unit by placing it before the metric type (distribution, gauge, etc) tag. The UI may still change but since this is feature flagged (i.e. we only request the unit data if the user has the flag) it's fine to do this for now.
Open in Explore, Edit Widget, and Add to Dashboard should all work with units optionally (i.e. creating a widget with a unit should carry the unit over when doing these flows). We should still be able to render old widgets and saved queries that were originally saved using the hardcoded
-unit