fix(dashboards): Support multiple aggregates and equations in categorical bar charts by gggritso · Pull Request #108071 · getsentry/sentry

gggritso · 2026-02-11T21:07:09Z

Categorical bar charts previously limited users to a single aggregate, which made equations impossible on the Errors dataset (where equations require their underlying aggregate to be selected and the equation). Also, switching to a categorical bar from a time series chart would silently drop all but the first aggregate, which is annoying.

This PR adopts the Big Number pattern: users can add multiple aggregates and equations, then select which one to plot via radio buttons. When only one aggregate exists, no radio buttons appear. This way, when users change back/forth between datasets and widget types, we don't drop any data.

There is added complexity now though, because the different actions might invalidate state (e.g., changing the selected aggregate might have to force change the sort). There were some stale closure issues in the reduces, so I ended up adding a new action dispatch for deleting an aggregate, which will now fall back to the correct aggregate where needed.

Fixes DAIN-1201

Categorical bar charts did not properly handle equations (e.g., `count(span.duration) / 5`). Equations were filtered out of the Visualize section, sort used the wrong format (`equation|...` instead of `equation[0]`), and changing the X-axis dropped equations from state causing server errors. - Include FieldValueKind.EQUATION in the Visualize section filter - Use equation[0] alias format for sort (matching getTableSortOptions) - Preserve equations in SET_CATEGORICAL_X_AXIS aggregate filter - Validate equation alias sorts when X-axis changes Refs DAIN-1201 Co-Authored-By: Claude <noreply@anthropic.com>

linear · 2026-02-11T21:07:13Z

DAIN-1201 Fix equation support in categorical bar charts

…ical bar charts Categorical bar charts previously limited users to a single aggregate, which made equations impossible on the Errors dataset (where equations require their underlying aggregate to coexist). This adopts the Big Number pattern: users can add multiple aggregates/equations and select which one to plot via radio buttons. The chart, sort, and display type switching all respect the selection. Fixes DAIN-1201

static/app/views/dashboards/widgetBuilder/components/visualize/index.tsx

static/app/views/dashboards/widgetBuilder/utils/convertBuilderStateToWidget.ts

… aggregates When deleting an aggregate before the selected one, the index now decrements to keep pointing at the same aggregate. When deleting the selected item itself, the index resets to undefined (defaults to last). Previously only the last-item deletion was handled, leaving a stale index that could go out of bounds.

static/app/views/dashboards/widgetBuilder/components/visualize/index.tsx

…elete index check Two fixes from automated review: 1. convertBuilderStateToWidget: The defaultSort fallback for categorical bar used the raw equation|... string format. The API expects the equation[N] alias format. Now computes the correct alias index. 2. visualize/index: The delete handler used >= which also caught deletions after the selected aggregate, incorrectly resetting the radio. Changed to === so only deleting the selected item resets it.

static/app/views/dashboards/widgetBuilder/components/visualize/index.tsx

…ional SET_CATEGORICAL_AGGREGATE previously recomputed sort unconditionally using selectedAggregate from the closure, which could be stale during deletions (dispatch order: SET_CATEGORICAL_AGGREGATE runs before SET_SELECTED_AGGREGATE updates the index). Now only recomputes sort when the current sort field is no longer present in the new aggregates, matching how SET_FIELDS works for tables. This avoids the stale-index problem entirely.