feat(aci): Add issue type filter to old alerts#108273
Conversation
malwilley
changed the title
github-actions
bot
added
the
Scope: Backend
malwilley
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| value = forms.ChoiceField(choices=list(TYPE_CHOICES.items())) | ||
|
|
||
|
|
||
| class IssueTypeFilter(EventFilter): |
There was a problem hiding this comment.
Do we need this so it shows up in the UI? (we aren't using these for processing anymore, so just want to confirm we need this class -- i could see it being needed for the legacy UI or because of API translation layers)
| label = "The issue's type is {include} {value}" | ||
| prompt = "The issue's type is ..." | ||
|
|
||
| def _passes(self, group: Group) -> bool: |
There was a problem hiding this comment.
🤔 since we're planning on deleting these filters, should we import the data condition evaluation and reuse that here to DRY up the code a little? (in general, i wouldn't recommend crossing app boundaries in that way, but since these are related and we're planning to delete this it might be nice to reduce the overhead of any updates / changes until we can clean everything up)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| type_matches = group.issue_type == value | ||
| return type_matches if include_type else not type_matches | ||
|
|
||
| return False |
There was a problem hiding this comment.
Boolean include option misinterpreted
Low Severity
include_type treats any non-"false" value as include, so if include is ever passed as a boolean False, the filter interprets it as include rather than exclude, producing the opposite result.
malwilley
deleted the
malwilley/feat/add-issue-type-filter-to-old-alerts
branch
2 participants
Ref ISWF-1991
Depends on #108241 (merge that first)
We already has an issue type data condition for workflow engine. This adds an issue type rule filter and the compatibility code which translates between the old models and new.