chore(explore): Remove TraceItemAttributeContext provider pattern by nsdeschenes · Pull Request #108552 · getsentry/sentry

nsdeschenes · 2026-02-19T19:11:47Z

Summary

Migrates all consumers of TraceItemAttributeProvider context to pass config directly to useTraceItemAttributes / useTraceItemTags, then removes the deprecated provider infrastructure entirely.

This is the follow-up to #108019 (EXP-726) which added config-based overloads. This PR (EXP-727) completes the migration.

Highly recommend review with whitespace hidden.

Ticket: EXP-727

linear · 2026-02-19T19:11:50Z

EXP-727 Replace instances of the trace provider context

nsdeschenes · 2026-02-19T19:12:04Z

@sentry review

nsdeschenes · 2026-02-19T19:12:06Z

@cursor review

static/app/views/alerts/rules/metric/eapField.tsx

nsdeschenes · 2026-02-19T19:54:29Z

@sentry review

nsdeschenes · 2026-02-19T19:54:33Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

static/app/views/alerts/rules/metric/ruleConditionsForm.tsx

DominikB2014

lgtm! One small nit
there's a bunch of duplicate attribute configs, any thoughts if we just create a hook per trace item type i.e useLogsTraceItemAttributes({enabled: boolean = true, type: 'number' | 'string', ..., we could keep the generic one too for any dynamic use case if needed

nsdeschenes · 2026-03-03T16:01:07Z

lgtm! One small nit there's a bunch of duplicate attribute configs, any thoughts if we just create a hook per trace item type i.e useLogsTraceItemAttributes({enabled: boolean = true, type: 'number' | 'string', ..., we could keep the generic one too for any dynamic use case if needed

~~Yes! this is on the books as a follow up!~~

Feeling like should just get this done with, going to add it in quickly.

static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.tsx

static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts

…eItemAttributes Rename deprecated useTraceItemAttributesWithConfig calls to useTraceItemAttributes in all consumers and remove the deprecated export. These callers already pass config objects directly.

… directly Migrate callers that relied on TraceItemAttributeProvider context to pass TraceItemAttributeConfig directly. Move search state into toolbar components. Remove provider wrappers that only existed to serve these callers.

…plore callers Update spanTagsContext's useTraceItemTags to accept a TraceItemAttributeConfig as the first argument. Migrate all explore callers to pass config directly instead of relying on the context provider. Key changes: - spanTagsContext.tsx: require config param, pass through to useTraceItemAttributes - useSortByFields.tsx: accept config param, callers pass it - toolbar components (visualize, groupBy): move search state into component, remove TraceItemAttributeProvider wrapper - spansTabSearchSection.tsx: pass config to all useTraceItemTags calls, remove provider wrapper for cross-event search bars - tables, multiquery, and other explore callers: pass spansConfig

Create useWidgetBuilderTraceItemConfig helper hook that extracts the dataset → TraceItemAttributeConfig mapping logic from TraceItemAttributeProviderFromDataset. Migrate all widget builder consumers (visualize, groupBySelector, sortBySelector, xAxisSelector, exploreArithmeticBuilder) to use the new hook and pass config to useTraceItemTags.

…ecated code All consumers have been migrated to pass config directly. This commit: - Removes TraceItemAttributeProvider, TraceItemAttributeContext, and overload resolution helpers from traceItemAttributeContext.tsx - Simplifies useTraceItemAttributes to only accept (config, type?, hiddenKeys?) - Removes provider wrappers from spans/content.tsx, logs/content.tsx, multiQueryMode/content.tsx, newWidgetBuilder.tsx - Deletes InsightsSpanTagProvider and removes it from 6 insights consumers - Removes provider wrappers from 8 additional insights pages and metricsSection.tsx

…ppers Remove TraceItemAttributeProvider from test wrappers across all spec files. Tests already mock the /trace-items/attributes/ API endpoint, so the components' internal useTraceItemAttributes calls with config will hit those mocks directly. Also update useTraceItemTags mock signatures to match the new (config, type?, hiddenKeys?) signature.

- Add back TraceItemDataset import to logsTab.tsx (needed for config) - Add config param to useSortByFields.spec.tsx test calls

Pass the selected alert project into EAPField and include it in trace item attribute config so aggregate options stay scoped to the alert project. Also remove the now-unnecessary EAPField wrapper export. Co-authored-by: Cursor <cursoragent@cursor.com>

Clean up unnecessary React Fragment wrappers in metric rule conditions and multi-query mode tests to simplify render trees without behavior changes. Co-authored-by: Cursor <cursoragent@cursor.com>

Move dataset-specific trace item wrappers into a single context and remove spanTagsContext to cut duplicate hook layers. Migrate core dashboards, alerts, and explore callsites to wrapper hooks so trace item config boilerplate is no longer repeated. Co-Authored-By: Claude <noreply@anthropic.com> Made-with: Cursor

Replace direct useTraceItemAttributes config usage in remaining explore, logs, insights, replay, and widget builder callsites with dataset-specific wrapper hooks or useTraceItemDatasetAttributes where the dataset is dynamic. Co-Authored-By: Claude <noreply@anthropic.com> Made-with: Cursor

Update widget builder and explore specs to mock the new attribute wrapper hooks and return attribute-shaped results. This keeps tests aligned with the migrated hook APIs and removes legacy tag-hook assumptions. Co-Authored-By: Claude <noreply@anthropic.com> Made-with: Cursor

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

static/app/components/preprod/preprodSearchBar.tsx

static/app/views/alerts/rules/metric/eapField.tsx

DominikB2014 · 2026-03-04T16:02:33Z

lgtm!

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 19, 2026

vercel bot deployed to Preview February 19, 2026 19:14 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/views/alerts/rules/metric/eapField.tsx Outdated Show resolved Hide resolved

nsdeschenes force-pushed the nd/EXP-727/chore-remove-trace-item-attribute-context branch from 5a7161c to cb432a9 Compare February 19, 2026 19:52

vercel bot deployed to Preview February 19, 2026 19:55 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

vercel bot deployed to Preview February 20, 2026 11:35 View deployment

nsdeschenes marked this pull request as ready for review February 20, 2026 16:54

nsdeschenes requested review from a team as code owners February 20, 2026 16:54

sentry bot reviewed Feb 20, 2026

View reviewed changes

static/app/views/alerts/rules/metric/ruleConditionsForm.tsx Outdated Show resolved Hide resolved

DominikB2014 approved these changes Mar 3, 2026

View reviewed changes

nsdeschenes force-pushed the nd/EXP-727/chore-remove-trace-item-attribute-context branch from 771e88c to f424567 Compare March 3, 2026 16:46

vercel bot had a problem deploying to Preview March 3, 2026 16:47 Failure

sentry bot reviewed Mar 3, 2026

View reviewed changes

static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.tsx Outdated Show resolved Hide resolved

cursor bot reviewed Mar 3, 2026

View reviewed changes

static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.tsx Outdated Show resolved Hide resolved

static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview March 3, 2026 17:27 View deployment

sentry bot reviewed Mar 3, 2026

View reviewed changes

static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts Show resolved Hide resolved

vercel bot deployed to Preview March 3, 2026 19:58 View deployment

nsdeschenes force-pushed the nd/EXP-727/chore-remove-trace-item-attribute-context branch from 976badd to 8dff894 Compare March 4, 2026 11:43

vercel bot deployed to Preview March 4, 2026 11:46 View deployment

sentry bot reviewed Mar 4, 2026

View reviewed changes

static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts Show resolved Hide resolved

nsdeschenes and others added 17 commits March 4, 2026 09:49

chore(explore): Replace useTraceItemAttributesWithConfig with useTrac…

a0afbcb

…eItemAttributes Rename deprecated useTraceItemAttributesWithConfig calls to useTraceItemAttributes in all consumers and remove the deprecated export. These callers already pass config objects directly.

fix(explore): Fix missing TraceItemDataset import and test config param

50fbb4c

- Add back TraceItemDataset import to logsTab.tsx (needed for config) - Add config param to useSortByFields.spec.tsx test calls

chore(explore): Remove redundant fragment wrappers

122125b

Clean up unnecessary React Fragment wrappers in metric rule conditions and multi-query mode tests to simplify render trees without behavior changes. Co-authored-by: Cursor <cursoragent@cursor.com>

🔥 Remove extra useMemo

44f7304

Revert logic for newWidgetBuilder

4bc609b

Fix up issues with useWidgetBuilderTraceItemConfig

6d3705a

Fix up messageSpanSamplesPanel

4c9fa16

fix: Resolve CI issues

9268456

nsdeschenes force-pushed the nd/EXP-727/chore-remove-trace-item-attribute-context branch from 8dff894 to 9268456 Compare March 4, 2026 13:50

vercel bot deployed to Preview March 4, 2026 13:53 View deployment

🔥 Remove extra config objects

ecf0aaf

vercel bot deployed to Preview March 4, 2026 14:32 View deployment

cursor bot reviewed Mar 4, 2026

View reviewed changes

static/app/components/preprod/preprodSearchBar.tsx Outdated Show resolved Hide resolved

static/app/views/alerts/rules/metric/eapField.tsx Show resolved Hide resolved

nsdeschenes added 2 commits March 4, 2026 11:07

🐛 Fix up preprod search bar

5468c1c

🐛 Fix up eap field and rule conditions form

93c9c56

vercel bot deployed to Preview March 4, 2026 15:11 View deployment

nsdeschenes merged commit f8af911 into master Mar 4, 2026
60 checks passed

nsdeschenes deleted the nd/EXP-727/chore-remove-trace-item-attribute-context branch March 4, 2026 17:36

Uh oh!

Conversation

nsdeschenes commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

linear bot commented Feb 19, 2026

Uh oh!

nsdeschenes commented Feb 19, 2026

Uh oh!

nsdeschenes commented Feb 19, 2026

Uh oh!

Uh oh!

nsdeschenes commented Feb 19, 2026

Uh oh!

nsdeschenes commented Feb 19, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DominikB2014 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nsdeschenes commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DominikB2014 commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nsdeschenes commented Feb 19, 2026 •

edited

Loading

DominikB2014 left a comment •

edited

Loading

nsdeschenes commented Mar 3, 2026 •

edited

Loading