Skip to content

fix(monitors): Remove radius on schedule preview when overlapping panels#108673

Merged
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/fix-monitors-remove-radius-on-schedule-preview-when-overlapping-panels
Feb 23, 2026
Merged

fix(monitors): Remove radius on schedule preview when overlapping panels#108673
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/fix-monitors-remove-radius-on-schedule-preview-when-overlapping-panels

Conversation

@evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Feb 20, 2026

The sticky schedule preview panel sits above the form sections below it.
When scrolled such that a form panel slides under the preview, the rounded
bottom corners of the preview looked visually odd against the panel
beneath.

Adds a scroll listener that checks whether the sticky container's bottom
edge falls within any sibling form panel, and removes the bottom border
radius when it does. The threshold is inset by the border radius so the
transition happens right as the two corners would otherwise meet, rather
than while both radii are still visible side-by-side.

Before
image

After
image

Also detects when it's no longer in a panel

image

The sticky schedule preview panel sits above the form sections below it.
When scrolled such that a form panel slides under the preview, the rounded
bottom corners of the preview looked visually odd against the panel
beneath. We already dealt with this by removing the border when it
stickies. But it's not always overlapping another panel when stickied.

Adds a scroll listener that checks whether the sticky container's bottom
edge falls within any sibling form panel, and removes the bottom border
radius when it does. The threshold is inset by the border radius so the
transition happens right as the two corners would otherwise meet, rather
than while both radii are still visible side-by-side.
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner February 20, 2026 10:07
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team February 20, 2026 10:07
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 20, 2026
Copy link
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🥇

@linear
Copy link

linear bot commented Feb 20, 2026

@evanpurkhiser evanpurkhiser merged commit 97aa5b7 into master Feb 23, 2026
66 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-monitors-remove-radius-on-schedule-preview-when-overlapping-panels branch February 23, 2026 07:52
priscilawebdev pushed a commit that referenced this pull request Feb 24, 2026
…els (#108673)

The sticky schedule preview panel sits above the form sections below it.
When scrolled such that a form panel slides under the preview, the
rounded
bottom corners of the preview looked visually odd against the panel
beneath.

Adds a scroll listener that checks whether the sticky container's bottom
edge falls within any sibling form panel, and removes the bottom border
radius when it does. The threshold is inset by the border radius so the
transition happens right as the two corners would otherwise meet, rather
than while both radii are still visible side-by-side.

Before
<img width="133" height="236" alt="image"
src="https://github.com/user-attachments/assets/40ba6cf8-47c8-4c8b-8cbd-d443e9c11ddc"
/>

After
<img width="120" height="183" alt="image"
src="https://github.com/user-attachments/assets/e68adad5-47d0-481f-8133-a4f2787c27a9"
/>

Also detects when it's no longer in a panel

<img width="188" height="214" alt="image"
src="https://github.com/user-attachments/assets/0d5ed7b7-6a47-4716-aa75-40820717c5a9"
/>
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
…els (#108673)

The sticky schedule preview panel sits above the form sections below it.
When scrolled such that a form panel slides under the preview, the
rounded
bottom corners of the preview looked visually odd against the panel
beneath.

Adds a scroll listener that checks whether the sticky container's bottom
edge falls within any sibling form panel, and removes the bottom border
radius when it does. The threshold is inset by the border radius so the
transition happens right as the two corners would otherwise meet, rather
than while both radii are still visible side-by-side.

Before
<img width="133" height="236" alt="image"
src="https://github.com/user-attachments/assets/40ba6cf8-47c8-4c8b-8cbd-d443e9c11ddc"
/>

After
<img width="120" height="183" alt="image"
src="https://github.com/user-attachments/assets/e68adad5-47d0-481f-8133-a4f2787c27a9"
/>

Also detects when it's no longer in a panel

<img width="188" height="214" alt="image"
src="https://github.com/user-attachments/assets/0d5ed7b7-6a47-4716-aa75-40820717c5a9"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants