chore(ACI): Add render_label for ticketing providers#108795
chore(ACI): Add render_label for ticketing providers#108795
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
...ications/notification_action/issue_alert_registry/handlers/sentry_app_issue_alert_handler.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
|
|
||
| class TicketingIssueAlertHandler(BaseIssueAlertHandler): | ||
| label = "Create a ticket in {integration}" |
There was a problem hiding this comment.
maybe 'label_template' to make it clearer this isn't intended to be used as-is and to make a comment about what we replace and how seem appropriate?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| name="GitHub Enterprise", | ||
| external_id="github_enterprise:1", | ||
| ) | ||
| action_data = {**GITHUB_ACTION_DATA_BLOBS[3]} |
There was a problem hiding this comment.
Test uses wrong constant for GitHub Enterprise data
Low Severity
test_github_enterprise_action references GITHUB_ACTION_DATA_BLOBS[3] to get a GitHub Enterprise data blob. This blob happens to have the GitHub Enterprise action id, but it lives inside the GITHUB_ACTION_DATA_BLOBS list, which is misleading. The reference is fragile — if anyone reorders or adds entries to that list, this test would silently use the wrong blob. A dedicated GITHUB_ENTERPRISE_ACTION_DATA_BLOBS constant (similar to how JIRA_SERVER_ACTION_DATA_BLOBS exists separate from JIRA_ACTION_DATA_BLOBS) would make the intent clear and avoid index-based coupling.
Follow up to #108419 to add the ticketing providers. I tried to add sentry apps in this but it's going to require a larger change so I'll keep that as a separate follow up.
Follow up to #108419 to add the ticketing providers. I tried to add sentry apps in this but it's going to require a larger change so I'll keep that as a separate follow up.
2 participants
Follow up to #108419 to add the ticketing providers.
I tried to add sentry apps in this but it's going to require a larger change so I'll keep that as a separate follow up.