feat(flags): Remove graduated data-browsing-8 feature flags#108808
feat(flags): Remove graduated data-browsing-8 feature flags#108808
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tests/snuba/api/endpoints/test_organization_trace_item_attributes_ranked.py
Show resolved
Hide resolved
|
Turns out that there's no Seer on self-hosted, so I think we need to keep |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…ibutes, performance-web-vitals-seer-suggestions, trace-view-quota-exceeded-banner, tracing-onboarding-new-ui, project-detail-apple-app-hang-rate) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove dead code left behind by the graduation of performance-web-vitals-seer-suggestions and tracing-onboarding-new-ui feature flags: - Remove test_no_feature test that asserts 404 from a removed feature gate - Remove showNewUi variable and dead legacy UI branch - Remove has_feature method and dead 404 check Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This flag depends on Seer which is not available in self-hosted deployments. Adding the flag back to keep it gated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The flag was kept in temporary.py (Seer dependency) but was removed from the test fixtures, causing tests to fail since the component still checks for the flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wedamija
force-pushed
the
flag-burner/ga/data-browsing-8
branch
from
784ee28 to
d3dd7a6
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| onClearSelection: () => { | ||
| setChartSelection(null); | ||
| }, | ||
| disabled: !organization.features.includes( | ||
| 'performance-spans-suspect-attributes' | ||
| ), | ||
| disabled: false, | ||
| actionMenuRenderer: params => { | ||
| return ( | ||
| <FloatingTrigger chartIndex={index} params={params} setTab={setTab} /> |
There was a problem hiding this comment.
Bug: The feature flag organizations:performance-spans-suspect-attributes was not removed from metricDetectorTriggeredSection.tsx, which will cause the AttributeComparisonSection to disappear for all users once the flag is decommissioned.
Severity: HIGH
Suggested Fix
Remove the <Feature features="organizations:performance-spans-suspect-attributes"> wrapper component from around the <AttributeComparisonSection> in metricDetectorTriggeredSection.tsx. This will ensure the section is always rendered, consistent with the feature's graduation.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/explore/spans/charts/index.tsx#L307-L313
Potential issue: The pull request aims to graduate the
`organizations:performance-spans-suspect-attributes` feature flag, making the feature
available to all users. However, the cleanup is incomplete. A reference to this flag
remains in `metricDetectorTriggeredSection.tsx`, where it wraps the
`AttributeComparisonSection` component. Once the feature flag is removed from the
backend configuration, the `Feature` component will evaluate `hasFeature()` as `false`
and, by default, return `null`. This will cause the `AttributeComparisonSection` to stop
rendering entirely, effectively disabling a feature that was intended to be permanently
enabled.
Did we get this right? 👍 / 👎 to inform future reviews.
…s flag The Feature wrapper around AttributeComparisonSection would cause it to stop rendering once the flag registration is removed from temporary.py.
2 participants
Summary
Removes 4 feature flags owned by data-browsing that have been enabled at 100% via flagpole with no conditions:
organizations:performance-spans-suspect-attributesorganizations:trace-view-quota-exceeded-bannerorganizations:tracing-onboarding-new-uiprojects:project-detail-apple-app-hang-rateNote:
organizations:performance-web-vitals-seer-suggestionswas removed from this PR because it depends on Seer, which is not available in self-hosted deployments.These flags have been fully rolled out and their behavior is now the default.
Test plan
🤖 Generated with Claude Code