feat(flags): Remove graduated team-replay user-feedback AI flags#108811
feat(flags): Remove graduated team-replay user-feedback AI flags#108811
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| const summary = feedbackIssue.metadata.summary; | ||
| const isAiSummaryEnabled = | ||
| areAiFeaturesAllowed && organization.features.includes('user-feedback-ai-titles'); | ||
| const isAiSummaryEnabled = areAiFeaturesAllowed; |
There was a problem hiding this comment.
Huh I'm surprised linter doesn't yell -- ideally we'd get rid of this in a follow-up
|
@billyvg I just had a thought - is this relying on Seer? Since Seer isn't in self hosted, I might not be able to remove these... |
|
Maybe it's not a big deal, since this just seems to be trying to read these summaries from a cache, and if not present then it won't fail |
Ah yeah it does rely on Seer |
I think it's fine in the end - the seer features are gated by another check, this just helps us clean up some released flags within ai features. So I think I'll still go ahead and remove |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wedamija
force-pushed
the
flag-burner/ga/team-replay-1
branch
from
5b93e0e to
d7f82d9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const summary = feedbackIssue.metadata.summary; | ||
| const isAiSummaryEnabled = | ||
| areAiFeaturesAllowed && organization.features.includes('user-feedback-ai-titles'); | ||
| const isAiSummaryEnabled = areAiFeaturesAllowed; |
There was a problem hiding this comment.
Redundant variable assignment creates unnecessary code
Low Severity
The variable isAiSummaryEnabled is assigned the value of areAiFeaturesAllowed without any transformation, creating an unnecessary alias. The variable is used in only two places (lines 55 and 69) where areAiFeaturesAllowed could be used directly. This adds indirection without providing meaningful semantic value, making the code slightly harder to maintain.
After the flag removal in #108811, isAiSummaryEnabled was just an alias for areAiFeaturesAllowed. Use areAiFeaturesAllowed directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…8811) ## Summary Removes 5 user-feedback AI feature flags owned by team-replay that have been enabled at 100% via flagpole with no conditions: - `organizations:user-feedback-ai-categorization` - `organizations:user-feedback-ai-categorization-features` - `organizations:user-feedback-ai-summaries` - `organizations:user-feedback-ai-summaries-cache` - `organizations:user-feedback-ai-titles` These flags have been fully rolled out and their behavior is now the default. ## Test plan - [ ] CI passes - [ ] Corresponding sentry-options-automator PR to remove flagpole config 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…8811) ## Summary Removes 5 user-feedback AI feature flags owned by team-replay that have been enabled at 100% via flagpole with no conditions: - `organizations:user-feedback-ai-categorization` - `organizations:user-feedback-ai-categorization-features` - `organizations:user-feedback-ai-summaries` - `organizations:user-feedback-ai-summaries-cache` - `organizations:user-feedback-ai-titles` These flags have been fully rolled out and their behavior is now the default. ## Test plan - [ ] CI passes - [ ] Corresponding sentry-options-automator PR to remove flagpole config 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary - Follow-up to #108811 (merged) per review comment from @billyvg - After the `user-feedback-ai-titles` flag removal, `isAiSummaryEnabled` became a redundant alias for `areAiFeaturesAllowed` - Removes the variable and uses `areAiFeaturesAllowed` directly ## Test plan - [x] `feedbackItemUsername.spec.tsx` passes (9/9 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
Summary
Removes 5 user-feedback AI feature flags owned by team-replay that have been enabled at 100% via flagpole with no conditions:
organizations:user-feedback-ai-categorizationorganizations:user-feedback-ai-categorization-featuresorganizations:user-feedback-ai-summariesorganizations:user-feedback-ai-summaries-cacheorganizations:user-feedback-ai-titlesThese flags have been fully rolled out and their behavior is now the default.
Test plan
🤖 Generated with Claude Code