feat(preprod): Track distribution state on PreprodArtifact

[runningcode]

Mirror the existing size analysis NOT_RAN pattern for build distribution. When the update endpoint evaluates distribution eligibility, it records why distribution was skipped (quota, feature disabled, filtered) so the frontend can display the reason in build details.

Changes:

• Add installable_app_error_code and installable_app_error_message fields to PreprodArtifact
• Add InstallableAppErrorCode enum (UNKNOWN, NO_QUOTA, SKIPPED, PROCESSING_ERROR)
• Update endpoint evaluates should_run_distribution and records the skip reason (mirroring the should_run_size pattern)
• DistributionInfo in the build details API exposes error_code and error_message

Scoped out (follow-up PRs):

• Listing endpoint filters for error-code artifacts
• Dedicated endpoint for launchpad to report distribution errors (mirroring ProjectPreprodSizeEndpoint)

Refs EME-842

[linear]

EME-842 Mirror size analysis NOT_RAN behavior in build distribution

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0027_add_distribution_state_fields.py

for 0027_add_distribution_state_fields in preprod

--
-- Add field distribution_state to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "distribution_state" integer NULL CHECK ("distribution_state" >= 0);
--
-- Add field distribution_skip_reason to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "distribution_skip_reason" varchar(32) NULL;

[chromy]

can_run_distro, distro_skip_reason = and below seems correct.

[chromy]

I don't think this is the correct endpoint to handle this.
The size one for example is handled here:
https://github.com/getsentry/sentry/blob/5205f1bcbc54415de4a8c371bea9cd754c3321e8/src/sentry/preprod/api/endpoints/project_preprod_size.py

project_preprod_artifact_update() is for the initial processing - not for uploading size/distro date or for updating the errors for the.

The flow is like:

monolith                                                        launchpad 

assemble()
task()
                                               kafka ----->  initial processing
project_preprod_artifact_update <-----  (returns req features)
                                                                       compute_size
                                                         <-----   upload size json
                                                                       compute_distro
                                                         <-----   upload distro build

for success and:

monolith                                                        launchpad 

assemble()
task()
                                               kafka ----->  initial processing
project_preprod_artifact_update <-----  (returns req features)
                                                                       compute_size
         ProjectPreprodSizeEndpoint<-----   set size error
                                                                       compute_distro
                                                         <-----   ?

for failure.

[chromy]

My diagram looks like line noise but hopefully that makes some sense, if not lets talk.

[chromy]

Same here - I'm not sure we want to hide these

[chromy]

Left some comments, maybe we could start just with NOT_RAN and leave the other two parts:

• updating list builds
• adding an endpoint for updating the distro error_code / error_message

to follow up PRs? I think keeping the PRs smaller might help.

[runningcode]

Thanks for the diagrams! I will just do the NOT_RAN part here and then I'll DM you if I have questions about the diagrams.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.}

[cursor]

Retry guard incomplete, may set erroneous error code

Medium Severity

The guard if head_artifact.installable_app_error_code is None: only prevents re-evaluation when distribution was previously skipped (error code set). When distribution was previously allowed, installable_app_error_code remains None, so on a launchpad retry the check re-runs. If conditions changed between calls (e.g., quota consumed by the first distribution request), an error code like NO_QUOTA gets written to an artifact that already had distribution initiated — creating an inconsistent state where the build details API shows both a successful distribution (is_installable=True) and an error code simultaneously.

 

[sentry]

Bug: When an artifact is rerun, the reset_artifact_data function does not clear distribution-specific error fields, leaving stale error data after a successful retry.
_{Severity: MEDIUM}

Suggested Fix

Update the reset_artifact_data function in preprod_artifact_rerun_analysis.py to also set installable_app_error_code and installable_app_error_message to None. This will ensure that stale error information is cleared before a rerun attempt.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/preprod/api/endpoints/project_preprod_artifact_update.py#L439-L448

Potential issue: When an artifact distribution fails and is subsequently rerun, the
function `reset_artifact_data` is called. This function clears general artifact error
fields like `error_code` and `error_message`, but it fails to clear
distribution-specific error fields, namely `installable_app_error_code` and
`installable_app_error_message`. If the rerun is successful, the distribution task sets
`installable_app_file_id`, but the stale error fields from the previous failed attempt
persist. This results in an inconsistent state where the artifact appears to have both
succeeded and failed simultaneously.

[chromy]

Yes, might be good to add this to:

sentry/src/sentry/preprod/api/endpoints/preprod_artifact_rerun_analysis.py

Line 270 in 6478b2b

def reset_artifact_data(preprod_artifact: PreprodArtifact) -> None:

[chromy]

lgtm