feat(ci): selective testing escape hatch#109136
Conversation
github-actions
bot
added
the
Scope: Backend
|
Umm... i'm going to delete the label syncer, it's been practically untouched in 4 years and wants to now delete a bunch of labels that we haven't defined in it: https://github.com/getsentry/sentry/actions/runs/22324782722/job/64592270442?pr=109136 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
joshuarli
force-pushed
the
ci-add-escape-hatch
branch
from
ae525f7 to
342641a
Compare
joshuarli
force-pushed
the
ci-add-escape-hatch
branch
from
342641a to
75aa507
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| id: calculate-shards | ||
| env: | ||
| SELECTED_TESTS_FILE: ${{ needs.prepare-selective-tests.outputs.has-selected-tests == 'true' && '.artifacts/selected-tests.txt' || '' }} | ||
| SELECTED_TESTS_FILE: "${{ !contains(github.event.pull_request.labels.*.name, 'Trigger: Override Selective Testing') && needs.prepare-selective-tests.outputs.has-selected-tests == 'true' && '.artifacts/selected-tests.txt' || '' }}" |
There was a problem hiding this comment.
Override label check may not apply
Medium Severity
The override behavior hinges on contains(github.event.pull_request.labels.*.name, 'Trigger: Override Selective Testing'). If the pull_request.labels list in the labeled event payload doesn’t yet include the newly applied label (or is truncated), SELECTED_TESTS_FILE stays set and the run won’t switch to the full suite despite the workflow being triggered by the override label.
Additional Locations (1)
There was a problem hiding this comment.
this label already exists
this adds the escape hatch for selective testing - apply the label `Trigger: Override Selective Testing` and backend-selective.yml will re-run, this time running the full suite!
this adds the escape hatch for selective testing - apply the label `Trigger: Override Selective Testing` and backend-selective.yml will re-run, this time running the full suite!
2 participants
this adds the escape hatch for selective testing - apply the label
Trigger: Override Selective Testingand backend-selective.yml will re-run, this time running the full suite!