ref(compactSelect) add prebuilt compactSelect menu components #109171
Merged
ref(compactSelect) add prebuilt compactSelect menu components #109171
Conversation
JonasBa
changed the title
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/components/pageFilters/project/projectPageFilter.tsx
Outdated
Show resolved
Hide resolved
JonasBa
force-pushed
the
jb/comapactselect/streamline-render
branch
from
8006a54 to
b538076
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JonasBa
force-pushed
the
jb/comapactselect/streamline-render
branch
from
b538076 to
45518a0
Compare
TkDodo
approved these changes
Feb 24, 2026
Collaborator
TkDodo
left a comment
TkDodo
left a comment
There was a problem hiding this comment.
discoverability might be a problem here. I wouldn’t know that I can use menuComponents inside a compactSelect. But then again, I had a similar problem with trigger and it became OverlayTrigger which also isn’t great I think 😅
Member
Author
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
Adds the prebuild components to CompactSelect. These were previously only defined in HybridFilters, but they should actually exist at a lower lever given their wide use. I am open to better naming, MenuComponents does not feel like the best choice, maybe something like CompactSelectComponents would have been better and more in line with the CompactSelect component
wedamija
pushed a commit
that referenced
this pull request
Feb 24, 2026
Adds the prebuild components to CompactSelect. These were previously only defined in HybridFilters, but they should actually exist at a lower lever given their wide use. I am open to better naming, MenuComponents does not feel like the best choice, maybe something like CompactSelectComponents would have been better and more in line with the CompactSelect component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the prebuild components to CompactSelect. These were previously only defined in HybridFilters, but they should actually exist at a lower lever given their wide use.
I am open to better naming, MenuComponents does not feel like the best choice, maybe something like CompactSelectComponents would have been better and more in line with the CompactSelect component