ref(compactSelect) use MenuComponents for CompactSelect Slots#109198
Merged
ref(compactSelect) use MenuComponents for CompactSelect Slots#109198
Conversation
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Feb 24, 2026
JonasBa
commented
Feb 24, 2026
| }} | ||
| menuWidth="280px" | ||
| // eslint-disable-next-line @sentry/scraps/restrict-jsx-slot-children | ||
| menuFooter={<OrgFooterMessage />} |
Member
Author
There was a problem hiding this comment.
Opted to just update the CTA button and left the rest
JonasBa
commented
Feb 24, 2026
JonasBa
commented
Feb 24, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JonasBa
force-pushed
the
jb/eslint/compact-select-usage
branch
from
4e7b563 to
1e449bd
Compare
The editAccessSelector was refactored to use MenuComponents.ApplyButton which renders 'Apply' instead of a custom button with 'Save Changes'. Update tests to match the new button text. Co-Authored-By: Claude <noreply@anthropic.com>
…TAButton priority - filterSelector: The Remove Filter button was migrated to MenuComponents.HeaderButton but the closeOverlay() call was dropped. Restore it by destructuring closeOverlay from menuHeaderTrailingItems. - menuComponents: CTAButton and CTALinkButton document that priority is locked, but didn't set it explicitly. Add priority="default" to match the previous behaviour of existing call sites. - addFilter.spec: Update test button name from 'Add Filter' to 'Apply' to match the MenuComponents.ApplyButton introduced in the refactor. Co-Authored-By: Claude <noreply@anthropic.com>
static/app/views/dashboards/widgetBuilder/components/visualize/selectRow.tsx
Show resolved
Hide resolved
natemoo-re
approved these changes
Feb 25, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Nice cleanup! Consistency over composability seems like a fair tradeoff here.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }} | ||
| /> | ||
| ); | ||
| }} |
Contributor
There was a problem hiding this comment.
Branch selector reset button loses descriptive label
Medium Severity
The branch filter header button was changed from "Reset to all branches" to the generic "Reset" label. MenuComponents.ResetButton omits children from its props and always renders "Reset", so the context-specific label was lost. In a branch filter, "Reset" alone is ambiguous; users may not understand it resets to "All Branches".
JonasBa
added a commit
that referenced
this pull request
Feb 25, 2026
Adds a configurable ESLint rule to `eslintPluginScraps` that restricts the JSX trees passed to specific slot props to a declared set of allowed elements. The rule is written in a generic way so that it can easily be extended to other component types. #109198 should address the violations and allow us to merge these changes --------- Co-authored-by: Claude <noreply@anthropic.com>
NicoHinderling
pushed a commit
that referenced
this pull request
Feb 25, 2026
Adds a configurable ESLint rule to `eslintPluginScraps` that restricts the JSX trees passed to specific slot props to a declared set of allowed elements. The rule is written in a generic way so that it can easily be extended to other component types. #109198 should address the violations and allow us to merge these changes --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors usage of CompactSelect footer and title trailing props to mostly use the newly created MenuComponent prebuilt elements. This standardizes on the sizing, naming as well as some behavior of the selects so that they appear and act in a consistent manner throughout the UI
Fix DE-713, DE-753, DE-863