Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sentry/seer/explorer/index_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -505,13 +505,18 @@ def get_issues_for_transaction(transaction_name: str, project_id: int) -> Transa

serialized_event = serialize(full_event, user=None, serializer=EventSerializer())

group_metadata = (group.data or {}).get("metadata", {})
issue_data_list.append(
IssueDetails(
id=group.id,
title=group.title,
short_id=group.qualified_short_id,
culprit=group.culprit,
transaction=full_event.transaction,
events=[serialized_event],
project=group.project_id,
filename=group_metadata.get("filename"),
function=group_metadata.get("function"),
)
)

Expand Down
4 changes: 4 additions & 0 deletions src/sentry/seer/sentry_data_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,15 @@ class TraceProfiles(BaseModel):
class IssueDetails(BaseModel):
id: int
title: str
short_id: str | None = None
culprit: str | None
transaction: str | None
events: list[dict[str, Any]]
metadata: dict[str, Any] = {}
message: str = ""
project: int | None = None
filename: str | None = None
function: str | None = None


class TransactionIssues(BaseModel):
Expand Down
97 changes: 97 additions & 0 deletions tests/sentry/seer/explorer/test_index_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,103 @@ def test_get_issues_for_transaction(self) -> None:
"tags" in issue.events[0] or issue.events[0].get("transaction") == transaction_name
)

def test_get_issues_for_transaction_populates_short_id_and_project(self) -> None:
"""Test that short_id and project fields are populated from the group."""
transaction_name = "api/orders/list"

event = self.store_event(
data={
"message": "Order processing failed",
"tags": [["transaction", transaction_name]],
"fingerprint": ["order-error"],
"platform": "python",
"timestamp": self.ten_mins_ago.isoformat(),
"level": "error",
},
project_id=self.project.id,
)

result = get_issues_for_transaction(transaction_name, self.project.id)

assert result is not None
assert len(result.issues) == 1

issue = result.issues[0]
group = event.group
assert issue.short_id == group.qualified_short_id
assert issue.project == group.project_id

def test_get_issues_for_transaction_populates_filename_and_function_from_metadata(
self,
) -> None:
"""Test that filename and function are populated from group metadata when the event has an exception with a stacktrace."""
transaction_name = "api/payments/process"

self.store_event(
data={
"exception": {
"values": [
{
"type": "ValueError",
"value": "Invalid payment amount",
"stacktrace": {
"frames": [
{
"filename": "payments/processor.py",
"function": "process_payment",
"lineno": 42,
"in_app": True,
}
]
},
}
]
},
"tags": [["transaction", transaction_name]],
"fingerprint": ["payment-error"],
"platform": "python",
"timestamp": self.ten_mins_ago.isoformat(),
"level": "error",
},
project_id=self.project.id,
)

result = get_issues_for_transaction(transaction_name, self.project.id)

assert result is not None
assert len(result.issues) == 1

issue = result.issues[0]
assert issue.filename == "payments/processor.py"
assert issue.function == "process_payment"

def test_get_issues_for_transaction_handles_missing_metadata_fields(self) -> None:
"""Test that filename and function are None when not present in group metadata."""
transaction_name = "api/auth/login"

# A simple message event without an exception stacktrace will not populate
# filename or function in the group metadata
self.store_event(
data={
"message": "Login failed",
"tags": [["transaction", transaction_name]],
"fingerprint": ["login-error"],
"platform": "python",
"timestamp": self.ten_mins_ago.isoformat(),
"level": "error",
},
project_id=self.project.id,
)

result = get_issues_for_transaction(transaction_name, self.project.id)

assert result is not None
assert len(result.issues) == 1

issue = result.issues[0]
assert issue.filename is None
assert issue.function is None

def test_get_issues_for_transaction_with_quotes(self) -> None:
"""Test that transaction names with quotes and search operators are properly escaped in search queries."""
# Test case 1: Transaction name with quotes that would break search syntax if not escaped
Expand Down
Loading