feat(assets): Add platformized assets page with dashboard migration flag#109240
Conversation
…browse-361-scaffold-basic-assets-module
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/utils/prebuiltConfigs/frontendAssets/frontendAssets.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ], | ||
| }, | ||
| ], | ||
| 1 |
There was a problem hiding this comment.
Third row widgets overlap second row at same y-position
Medium Severity
THIRD_ROW_WIDGETS is placed at y: 1, which is the same y-position as SECOND_ROW_WIDGETS. Since SECOND_ROW_WIDGETS occupies y: 1 with h: 1, the third row needs to start at y: 2 to avoid overlapping. The variable naming ("SECOND_ROW" vs "THIRD_ROW") clearly indicates these are meant to be separate rows. While the dashboard layout engine may auto-resolve the overlap by pushing widgets down, specifying the correct position avoids relying on that behavior and keeps layout intent clear.


Adds a platformized assets landing page that conditionally renders the
FRONTEND_ASSETSprebuilt dashboard when theinsights-frontend-assets-dashboard-migrationfeature flag is enabled.When the flag is off, the existing
ResourcesLandingPagerenders as before. When the flag is on, users see the prebuilt dashboard viaPrebuiltDashboardRenderer.Follows the same pattern used by web vitals (
useHasDashboardsPlatformizedWebVitals+PlatformizedWebVitalsOverview) and other platformized insight pages.Also fixes the
GlobalFilter.valueformat for thespan.opfilter in theFRONTEND_ASSETSprebuilt config — it was missing thetagKey:prefix required by the filter condition string format.Refs BROWSE-361