Skip to content

feat(assets): Add platformized assets page with dashboard migration flag#109240

Merged
DominikB2014 merged 6 commits intomasterfrom
dominikbuszowiecki/browse-361-scaffold-basic-assets-module
Feb 25, 2026
Merged

feat(assets): Add platformized assets page with dashboard migration flag#109240
DominikB2014 merged 6 commits intomasterfrom
dominikbuszowiecki/browse-361-scaffold-basic-assets-module

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Feb 24, 2026

Adds a platformized assets landing page that conditionally renders the FRONTEND_ASSETS prebuilt dashboard when the insights-frontend-assets-dashboard-migration feature flag is enabled.

When the flag is off, the existing ResourcesLandingPage renders as before. When the flag is on, users see the prebuilt dashboard via PrebuiltDashboardRenderer.

Follows the same pattern used by web vitals (useHasDashboardsPlatformizedWebVitals + PlatformizedWebVitalsOverview) and other platformized insight pages.

Also fixes the GlobalFilter.value format for the span.op filter in the FRONTEND_ASSETS prebuilt config — it was missing the tagKey: prefix required by the filter condition string format.

image image

Refs BROWSE-361

@linear
Copy link

linear bot commented Feb 24, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 24, 2026
@DominikB2014 DominikB2014 marked this pull request as ready for review February 25, 2026 16:13
@DominikB2014 DominikB2014 requested a review from a team as a code owner February 25, 2026 16:13
@DominikB2014 DominikB2014 enabled auto-merge (squash) February 25, 2026 16:20
@DominikB2014 DominikB2014 merged commit 4da949e into master Feb 25, 2026
62 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-361-scaffold-basic-assets-module branch February 25, 2026 16:28
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

],
},
],
1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third row widgets overlap second row at same y-position

Medium Severity

THIRD_ROW_WIDGETS is placed at y: 1, which is the same y-position as SECOND_ROW_WIDGETS. Since SECOND_ROW_WIDGETS occupies y: 1 with h: 1, the third row needs to start at y: 2 to avoid overlapping. The variable naming ("SECOND_ROW" vs "THIRD_ROW") clearly indicates these are meant to be separate rows. While the dashboard layout engine may auto-resolve the overlap by pushing widgets down, specifying the correct position avoids relying on that behavior and keeps layout intent clear.

Fix in Cursor Fix in Web

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants