Skip to content

feat(compactSelect): Use fzf for default search matching#109252

Merged
JonasBa merged 4 commits intomasterfrom
feat/compact-select-fzf-default-search
Feb 25, 2026
Merged

feat(compactSelect): Use fzf for default search matching#109252
JonasBa merged 4 commits intomasterfrom
feat/compact-select-fzf-default-search

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Feb 24, 2026

Make fuzzy search the default mode for CompactSelect search

Replace the case-insensitive substring filter with the fzf v1 algorithm
(already used by ProjectPageFilter) as the default search matcher when
`search` is enabled. Results are now sorted by relevance score rather
than maintaining their original order.

Co-Authored-By: Claude <noreply@anthropic.com>
@JonasBa JonasBa marked this pull request as ready for review February 24, 2026 23:10
@JonasBa JonasBa requested a review from a team as a code owner February 24, 2026 23:10
@JonasBa JonasBa enabled auto-merge (squash) February 25, 2026 15:17
@JonasBa JonasBa merged commit 9f90bf4 into master Feb 25, 2026
62 checks passed
@JonasBa JonasBa deleted the feat/compact-select-fzf-default-search branch February 25, 2026 15:24
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

if (result.end === -1) {
return {score: 0};
}
return {score: Math.max(1, result.score)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HybridFilter shift+click uses wrong filter logic

Medium Severity

shiftToggleRange in HybridFilter filters options with includes() to determine which options are "visible" for range selection, but CompactSelect now uses fzf by default. After a fuzzy search (e.g. "ption On" for "Option One"), the displayed options and the options used for shift+click range selection differ, so range selection can fall back to single toggle or use the wrong set of options.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll investigate this, but this must have existed before already given that we used fzf already

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants