Skip to content

fix(dashboards): Fix "Other" series colour not displaying correctly in new timeseries visualization #109321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardgou-sentry merged 1 commit into from
Feb 25, 2026
Merged

fix(dashboards): Fix "Other" series colour not displaying correctly in new timeseries visualization #109321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion static/app/views/dashboards/widgetCard/visualizationWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ function VisualizationWidgetContent({
timeSeries,
widget,
labelParts.filter(defined).join(SERIES_NAME_PART_DELIMITER),
seriesName
seriesName,
timeSeries.meta.isOther ? theme.tokens.dataviz.semantic.neutral : undefined
);
if (!plottable) {
return null;
Expand Down
14 changes: 10 additions & 4 deletions ...pp/views/dashboards/widgets/timeSeriesWidget/plottables/createPlottableFromTimeSeries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,24 @@ export function createPlottableFromTimeSeries(
timeSeries: TimeSeries,
widget: Widget,
alias?: string,
name?: string
name?: string,
color?: string
): Plottable | null {
const shouldStack = widget.queries[0]?.columns.length! > 0;

const {displayType, title} = widget;
switch (displayType) {
case DisplayType.LINE:
return new Line(timeSeries, {alias, name});
return new Line(timeSeries, {alias, name, color});
case DisplayType.AREA:
return new Area(timeSeries, {alias, name});
return new Area(timeSeries, {alias, name, color});
case DisplayType.BAR:
return new Bars(timeSeries, {stack: shouldStack ? title : undefined, alias, name});
return new Bars(timeSeries, {
stack: shouldStack ? title : undefined,
alias,
name,
color,
});
default:
return null;
}
Expand Down
Loading