Skip to content

fix(dashboards): Use equation prefix for ttid/ttfd contribution rate in Mobile Vitals#109525

Merged
gggritso merged 1 commit intomasterfrom
georgegritsouk/dain-1243-frontend
Feb 27, 2026
Merged

fix(dashboards): Use equation prefix for ttid/ttfd contribution rate in Mobile Vitals#109525
gggritso merged 1 commit intomasterfrom
georgegritsouk/dain-1243-frontend

Conversation

@gggritso
Copy link
Member

The Span Operations table in the Mobile Vitals dashboard uses ttid_contribution_rate() and ttfd_contribution_rate() as aggregates. When clicking "Open in Explore", these were silently dropped because getWidgetExploreUrl filters aggregates to only those present in eventView.getYAxisOptions() — which only recognizes functions known natively to Explore.

Prefixing with equation| fixes this: equations pass the isAggregateEquation() check in getYAxisOptions(), so they're included in the yAxis options and flow through to Explore correctly. The functions are defined in EAP (src/sentry/search/eap/spans/formulas.py), so Explore can resolve them.

The backend companion PR (#109521) adds these functions to the arithmetic allowed list so they pass equation validation.

Follows the same pattern as #108045 (Frontend Overview dashboard).

Note: This PR depends on #109521 landing first.

Fixes DAIN-1243

…in Mobile Vitals

The Span Operations table in the Mobile Vitals dashboard uses
`ttid_contribution_rate()` and `ttfd_contribution_rate()` as aggregates.
These functions are not recognized by Explore's yAxis filter, so they
were silently dropped when clicking "Open in Explore".

Prefix them with `equation|` so they route through the equations path,
which passes the yAxis filter and allows Explore to resolve them via EAP.

Refs DAIN-1243
Co-Authored-By: Claude <noreply@anthropic.com>
@linear
Copy link

linear bot commented Feb 26, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 26, 2026
@gggritso gggritso marked this pull request as ready for review February 27, 2026 14:16
@gggritso gggritso requested a review from a team as a code owner February 27, 2026 14:16
@gggritso gggritso merged commit b3b85e9 into master Feb 27, 2026
61 checks passed
@gggritso gggritso deleted the georgegritsouk/dain-1243-frontend branch February 27, 2026 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants