feat(codecov): Hide TA feature#109527
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
calvin-codecov
force-pushed
the
cy/hide_ta
branch
from
5748ff9 to
2f2100a
Compare
calvin-codecov
force-pushed
the
cy/hide_ta
branch
from
2f2100a to
639145b
Compare
| {showPreventNav(organization) ? ( | ||
| {showPreventNav() ? ( | ||
| <Container position="relative" height="100%"> | ||
| <SidebarLink | ||
| to={`/${prefix}/prevent/tests/`} | ||
| activeTo={`/${prefix}/prevent/`} | ||
| analyticsKey="prevent" | ||
| group={PrimaryNavGroup.PREVENT} | ||
| {...makeNavItemProps(PrimaryNavGroup.PREVENT)} | ||
| > | ||
| <IconPrevent /> | ||
| </SidebarLink> | ||
| <BetaBadge type="beta" /> | ||
| </Container> | ||
| ) : null} |
There was a problem hiding this comment.
Could nuke this too now. err, maybe not
It's things like PrimaryNavGroup.PREVENT and IconPrevent that might not be caught by knip
There was a problem hiding this comment.
Removing this block doesn't trigger knip since all icons are allowed and PrimaryNavGroup.Prevent is still used in other places with the new knip exception entries. Were you suggesting to remove this block too?
There was a problem hiding this comment.
No,doesn't matter imo.
It's more about identifying these things that knip is going to miss. in the 11K lines i wouldn't have spotted it... But doing that rm command in pieces will take too long. So idk, i expect there'll be extra things like these to identify and get over time. Also the backend will be more manual i expect too.
3 participants
Hide the Prevent TA feature