ref(dashboards): Replace maxFontSize prop with Container height in details widget#109599
Merged
DominikB2014 merged 5 commits intomasterfrom Feb 27, 2026
Conversation
… details widget Add an optional maxFontSize prop to AutoSizedText that caps the binary search upper bound, so the font never exceeds the given size regardless of available space. Use this in the details widget to render non-image resource span descriptions at up to 64px, scaling down to fit within the widget. Co-Authored-By: Claude <noreply@anthropic.com>
…t size Replace the hardcoded 64 with a named constant that references theme.size.xs, making the intent clear without needing to parse the px-suffixed token value. Co-Authored-By: Claude <noreply@anthropic.com>
…raint in details widget Remove the maxFontSize prop from AutoSizedText and Wrapper. Instead, cap the font size for resource span text by wrapping in a Container with a fixed height equal to RESOURCE_TEXT_MAX_FONT_SIZE_PX. AutoSizedText now always uses the parent height as its upper bound. Also adds a noPadding prop to Wrapper/AutoResizeParent to suppress the default xl padding when the container already constrains the size. Refs DAIN-1248 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
gggritso
approved these changes
Feb 27, 2026
DominikB2014
commented
Feb 27, 2026
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
DominikB2014
deleted the
dominikbuszowiecki/dain-1248-add-autosizing-to-details-widget-for-resource-span
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
maxFontSizeprop fromAutoSizedTextand theWrappercomponent in the details widget. Instead of capping font size through a prop, the resource span text case now wraps in aContainerwith a fixed height (RESOURCE_TEXT_MAX_FONT_SIZE_PX + 16px), lettingAutoSizedTextnaturally cap at the parent height.Also adds a
noPaddingprop toWrapper/AutoResizeParentso the defaultxlpadding can be suppressed when the container is already constraining the size.Refs DAIN-1248