Skip to content

feat(ai-conversations): onboarding#109651

Merged
obostjancic merged 7 commits intomasterfrom
ognjenbostjancic/tet-1829-ai-conversations-onboarding-docs
Mar 3, 2026
Merged

feat(ai-conversations): onboarding#109651
obostjancic merged 7 commits intomasterfrom
ognjenbostjancic/tet-1829-ai-conversations-onboarding-docs

Conversation

@obostjancic
Copy link
Member

@obostjancic obostjancic commented Mar 2, 2026

@linear
Copy link

linear bot commented Mar 2, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 2, 2026
…structors

Moves Set<string> type argument from variable declaration to constructor
call to satisfy @typescript-eslint/consistent-generic-constructors rule.
Also applies prettier formatting.
@obostjancic obostjancic marked this pull request as ready for review March 3, 2026 10:44
@obostjancic obostjancic requested a review from a team as a code owner March 3, 2026 10:44
@shellmayr
Copy link
Member

Looks good over all - one small thing I saw (not 100% that this is a problem): the "Other" snippet does not contain send_default_pii=True, so this will probably swallow the inputs if provided, right?

- Replace Header and OptionsWrapper styled components with Flex
  primitive from @sentry/scraps/layout per frontend guidelines
- Fix "View Conversations" button not dismissing onboarding by
  exposing refetch from useShowConversationOnboarding and using it
  as the onDismiss callback instead of reloadProjects()
…nboardingUtils

Deduplicate useOnboardingProject, PulseSpacer, PulsingIndicator,
HeaderText, SubTitle, and BulletList between agents and conversations
onboarding pages.
…egration snippet

The "Other" (manual) Python integration was missing send_default_pii=True,
which would cause LLM inputs/outputs to be filtered out.
…d replace SetupContent with Container

Move serverSideNodeIntegrations to agentIntegrations.tsx as
SERVER_SIDE_NODE_INTEGRATIONS export. Replace SetupContent styled
component with Container primitive.
@obostjancic
Copy link
Member Author

Good catch! You're right — the Python "Other" (manual) integration snippet was missing send_default_pii=True. Without it, LLM inputs/outputs would be filtered out by default PII scrubbing. Fixed in 8954047. All other Python integrations already had it; only "Other" was missing. Node.js/JS manual integrations were already correct.

— Claude Code

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@obostjancic obostjancic merged commit 0d09d21 into master Mar 3, 2026
60 checks passed
@obostjancic obostjancic deleted the ognjenbostjancic/tet-1829-ai-conversations-onboarding-docs branch March 3, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants