chore(grouping): remove grouphash cache expiry options#109677
Merged
Conversation
cvxluo
force-pushed
the
cvxluo/snmzytolqqrx
branch
from
50f2e4d to
e7418ad
Compare
github-actions
bot
added
the
Scope: Backend
cvxluo
force-pushed
the
cvxluo/snmzytolqqrx
branch
from
e7418ad to
64b6496
Compare
Contributor
Author
|
@lobsterkatie lmk if this makes sense |
shashjar
approved these changes
Mar 2, 2026
Member
shashjar
left a comment
shashjar
left a comment
There was a problem hiding this comment.
LGTM but would wait on @lobsterkatie's confirmation
lobsterkatie
approved these changes
Mar 2, 2026
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
Seems like a reasonable change.
| from sentry.utils.metrics import MutableTags | ||
| from sentry.utils.tag_normalization import normalized_sdk_tag_from_event | ||
|
|
||
| GROUPHASH_CACHE_EXPIRY_SECONDS = 60 |
Member
There was a problem hiding this comment.
Suggested change
| GROUPHASH_CACHE_EXPIRY_SECONDS = 60 | |
| # How long we cache both the existence of secondary grouphashes and grouphashes themselves. We use a | |
| # minute because experimentation showed that anything more than that didn't improve hit rates. | |
| GROUPHASH_CACHE_EXPIRY_SECONDS = 60 |
| project = self.project | ||
| get_cache_key = get_grouphash_object_cache_key | ||
| cache_expiry_seconds = options.get("grouping.ingest_grouphash_existence_cache_expiry") | ||
| cache_expiry_seconds = 60 |
Member
There was a problem hiding this comment.
Any reason not to use the constant in these tests, too?
cvxluo
force-pushed
the
cvxluo/snmzytolqqrx
branch
from
64b6496 to
1b9b07b
Compare
The cache expiry values were experimentally verified in #108274 to not need tuning (1, 2, and 5 minute TTLs all had identical hit rates). Hardcode the 60s TTL directly and remove the options. Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
force-pushed
the
cvxluo/snmzytolqqrx
branch
from
1b9b07b to
9229134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache expiry values were experimentally verified in #108274 to not need tuning (1, 2, and 5 minute TTLs all had identical hit rates). Hardcode the 60s TTL directly and remove the options.