ref(grouping): Small parameterization refactor#109690
Merged
lobsterkatie merged 13 commits intomasterfrom Mar 2, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
scttcper
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor to our message parameterization code, to make it a little easier to understand. Aside from a few renames and some added/tweaked comments, the main changes here are:
Make it so that
ParameterizationRegex.experimental_patternisNoneif there's no experimental pattern, rather than having it fall back to using the regular pattern. The fallback is now done in the creation ofEXPERIMENTAL_PARAMETERIZATION_REGEXES_MAP.Make the behavior of
Parameterizer.parametrize_w_regexmatch its docstring by a) making it take in a regex (as its docstring says it does), and b) removing the (non-existent) callback parameter from the docstring.Add a few test cases.
Skip the test testing experimental patterns if there are none.