ref(grouping): Clarify and add to xfail parameterization tests#109693
Merged
lobsterkatie merged 8 commits intomasterfrom Mar 2, 2026
Merged
ref(grouping): Clarify and add to xfail parameterization tests#109693lobsterkatie merged 8 commits intomasterfrom
lobsterkatie merged 8 commits intomasterfrom
Conversation
shashjar
approved these changes
Mar 2, 2026
lobsterkatie
deleted the
kmclb-refactor-and-add-broken-parameterization-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our test suite for message parameterization, we primarily test cases which are working as expected, but we also have two xfail tests to document cases where the parameterizer doesn't currently behave as we'd like it to. This serves as a rough TODO list, and lets us document cases we know we want to improve.
This PR does a small refactor of those tests, and adds a number of new test cases. Key changes:
Since the two tests are identical, combine them into one.
Pull the now-greatly-expanded set of test cases out into a variable to match the format of the good and experimental cases.
Add an
actualparameter to the test, so we can document the current parameterization behavior, and test against it as well.For ease of understanding, switch from using an
xfailtest testing==to using a passing test testing!=.